Skip to content

Revert "fix: do not load active extensions when no extensions in the recipe" #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 8 commits into from
Nov 25, 2025
Merged

Revert "fix: do not load active extensions when no extensions in the recipe" #5871

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb1820d
Revert "fix: do not load active extensions when no extensions in the …
DOsinga Nov 25, 2025
47e0a5a
Revert "fix: do not load active extensions when no extensions in the …
DOsinga Nov 25, 2025
0d20d2d
Merge branch 'revert-5282-lifei/cli-only-load-recipe-extension' of ht…
Nov 25, 2025
5cef6ac
docs: lowercase goose in remaining topics (#5861)
dianed-square Nov 24, 2025
4b4c5a5
docs: add DataHub MCP server extension documentation (#5769)
sam-at-block Nov 24, 2025
9811a0f
goose remote access (#5251)
michaelneale Nov 25, 2025
e0787bd
Revert "fix: do not load active extensions when no extensions in the …
DOsinga Nov 25, 2025
a150596
Merge branch 'revert-5282-lifei/cli-only-load-recipe-extension' of ht…
Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crates/goose-cli/src/recipes/extract_from_cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub fn extract_recipe_info_from_cli(
}
let input_config = InputConfig {
contents: recipe.prompt.filter(|s| !s.trim().is_empty()),
extensions_override: recipe.extensions.or(Some(vec![])),
extensions_override: recipe.extensions,
additional_system_prompt: recipe.instructions,
};

Expand Down Expand Up @@ -109,8 +109,7 @@ mod tests {
input_config.additional_system_prompt,
Some("test_instructions my_value".to_string())
);
assert!(input_config.extensions_override.is_some());
assert!(input_config.extensions_override.unwrap().is_empty());
assert!(input_config.extensions_override.is_none());

assert!(settings.is_some());
let settings = settings.unwrap();
Expand Down Expand Up @@ -175,8 +174,7 @@ mod tests {
input_config.additional_system_prompt,
Some("test_instructions my_value".to_string())
);
assert!(input_config.extensions_override.is_some());
assert!(input_config.extensions_override.unwrap().is_empty());
assert!(input_config.extensions_override.is_none());

assert!(settings.is_some());
let settings = settings.unwrap();
Expand Down
Loading