Revert "fix: do not load active extensions when no extensions in the recipe" #5871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recipe (…" This reverts commit 6f6f6f1.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #5282, which had changed the behavior to set extensions_override to an empty vector when recipes don't specify extensions. The revert restores the original behavior where extensions_override remains None when no extensions are specified in the recipe.
- Restores
extensions_overrideto pass throughrecipe.extensionsdirectly instead of convertingNonetoSome(vec![]) - Updates tests to expect
Noneforextensions_overridewhen recipes don't specify extensions - Fixes issues with scheduler and existing recipes caused by the previous change
lifeizhou-ap
approved these changes
Nov 25, 2025
Contributor
|
We can work around it by clearing the extensions from the config.yaml, feel free to revert. |
jsibbison-square
approved these changes
Nov 25, 2025
…recipe (…" This reverts commit 6f6f6f1. Signed-off-by: Douwe Osinga <douwe@squareup.com>
…tps://github.com/block/goose into revert-5282-lifei/cli-only-load-recipe-extension
Signed-off-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Sam Osborn <samosborn@squareup.com> Signed-off-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Douwe Osinga <douwe@squareup.com>
…recipe (…" This reverts commit 6f6f6f1. Signed-off-by: Douwe Osinga <douwe@squareup.com>
…tps://github.com/block/goose into revert-5282-lifei/cli-only-load-recipe-extension
mitchelsblockacct
added a commit
to mitchelsblockacct/goose
that referenced
this pull request
Nov 25, 2025
…ed-context-2 * upstream/main: Move recipe actions to bottom bar icon and edit goosehints to settings (block#5864) [docs] Add “Building a Social Media Agent” Blog Post (block#5844) deps: upgrade rmcp to 0.9.1 (block#5860) chore: suggest using text/markdown when fetching content (block#5854) Revert "fix: do not load active extensions when no extensions in the recipe" (block#5871) goose remote access (block#5251) docs: add DataHub MCP server extension documentation (block#5769) # Conflicts: # ui/desktop/src/components/ChatInput.tsx
wpfleger96
added a commit
that referenced
this pull request
Nov 26, 2025
* main: fix: adjust strange spacing in agent.rs (#5877) Move recipe actions to bottom bar icon and edit goosehints to settings (#5864) [docs] Add “Building a Social Media Agent” Blog Post (#5844) deps: upgrade rmcp to 0.9.1 (#5860) chore: suggest using text/markdown when fetching content (#5854) Revert "fix: do not load active extensions when no extensions in the recipe" (#5871) goose remote access (#5251) docs: add DataHub MCP server extension documentation (#5769)
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
…recipe" (block#5871) Signed-off-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Sam Osborn <samosborn@squareup.com> Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Sam Osborn <108367660+sam-at-block@users.noreply.github.com> Co-authored-by: Michael Neale <michael.neale@gmail.com> I don't understand why I get the DCO warnings Signed-off-by: Blair Allan <Blairallan@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5282
after all the discussion, I think it is better to revert this. this breaks the scheduler and a lot of recipes in the wild. let me know what internal systems we are using that would need to respect this.
/cc @jamadeo @tlongwell-block