Skip to content

Conversation

@michaelneale
Copy link
Collaborator

We don't need to run these on forks, also they won't work as require access to secrets, so they will only be run from branches.

@michaelneale michaelneale added the p0 Priority 0 - Critical/Urgent label Oct 29, 2025
@taniandjerry
Copy link
Contributor

Maybe rebase for failed CI test? Line 459 is it because the expected 128000 context limit for gpt-4o is supposed to be something different?

@jamadeo
Copy link
Collaborator

jamadeo commented Oct 30, 2025

If we want to, we can still do this in a way such that they'll work. pull_request_target can run on a fork and have secrets access, but of course we'll need to be careful with that since it will run untrusted code. It would still have to be run only on approval

@DOsinga
Copy link
Collaborator

DOsinga commented Oct 30, 2025

Maybe rebase for failed CI test? Line 459 is it because the expected 128000 context limit for gpt-4o is supposed to be something different?

that test is somehow flaky

@taniandjerry taniandjerry merged commit 04cf52e into main Oct 30, 2025
19 of 20 checks passed
@taniandjerry taniandjerry deleted the micn/no-fork-smoke-test branch October 30, 2025 17:33
@taniandjerry
Copy link
Contributor

If we want to, we can still do this in a way such that they'll work. pull_request_target can run on a fork and have secrets access, but of course we'll need to be careful with that since it will run untrusted code. It would still have to be run only on approval

o:

zanesq added a commit that referenced this pull request Oct 30, 2025
* 'main' of github.com:block/goose: (81 commits)
  nextcamp - fix session resume when navigating back to chat in sidebar (#5370)
  feat/fix: set optional config params, and don't overwrite unset secrets (#5325)
  Stringly typed config (#5463)
  Fix: Compaction client <-> server sync  (#5481)
  docs: recipe activity parameter substitution (#5462)
  only run fork on branch PRs (#5461)
  docs: video on goose with apify mcp (#5472)
  Clear windows and fix build failure (#5452)
  Add menu option for setting window always on top (#5429)
  Delete environment variable (#5479)
  chore: upgrade rmcp to 0.8.3 (#5458)
  docs: add "Building Custom Tools and Extensions for Goose" (#5469)
  Doc (Blog): Managing goose Configurations Across Multiple Projects (#5467)
  apify doc fix (#5460)
  Stream token usage on every agent message (#5342)
  rpm install in /opt/Goose to avoid conflicts with chrome-sandbox (#5421)
  Don't disable extensions after they fail to activate in new chat session (#5464)
  Add OTLP logs layer (#5386)
  openapi to locust load test generator recipe (#5447)
  technical debt tracker recipe (#5451)
  ...

# Conflicts:
#	ui/desktop/src/components/ChatInput.tsx
michaelneale added a commit that referenced this pull request Oct 31, 2025
* main: (45 commits)
  Change Recipes Test Script (#5457)
  Goose recover (#5450)
  don't start the default provider (#5351)
  keep the order of keys in config.yaml (#5468)
  Removed drafts and agentIsReady in ChatInput (#5366)
  nextcamp - fix session resume when navigating back to chat in sidebar (#5370)
  feat/fix: set optional config params, and don't overwrite unset secrets (#5325)
  Stringly typed config (#5463)
  Fix: Compaction client <-> server sync  (#5481)
  docs: recipe activity parameter substitution (#5462)
  only run fork on branch PRs (#5461)
  docs: video on goose with apify mcp (#5472)
  Clear windows and fix build failure (#5452)
  Add menu option for setting window always on top (#5429)
  Delete environment variable (#5479)
  chore: upgrade rmcp to 0.8.3 (#5458)
  docs: add "Building Custom Tools and Extensions for Goose" (#5469)
  Doc (Blog): Managing goose Configurations Across Multiple Projects (#5467)
  apify doc fix (#5460)
  Stream token usage on every agent message (#5342)
  ...
katzdave added a commit that referenced this pull request Nov 3, 2025
* 'main' of github.com:block/goose: (61 commits)
  [Autovisualiser] remove unnecessary content from mermaid HTML template (#5505)
  Improve subagents docs (#5484)
  FIX: prefer linux in WSL and add INSTALL_OS override for CLI (#5215)
  Propagate session ID in LLM and MCP requests (#5165)
  feat: YT Short for Canva MCP + goose (#5495)
  Change Recipes Test Script (#5457)
  Goose recover (#5450)
  don't start the default provider (#5351)
  keep the order of keys in config.yaml (#5468)
  Removed drafts and agentIsReady in ChatInput (#5366)
  nextcamp - fix session resume when navigating back to chat in sidebar (#5370)
  feat/fix: set optional config params, and don't overwrite unset secrets (#5325)
  Stringly typed config (#5463)
  Fix: Compaction client <-> server sync  (#5481)
  docs: recipe activity parameter substitution (#5462)
  only run fork on branch PRs (#5461)
  docs: video on goose with apify mcp (#5472)
  Clear windows and fix build failure (#5452)
  Add menu option for setting window always on top (#5429)
  Delete environment variable (#5479)
  ...
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Nov 7, 2025
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p0 Priority 0 - Critical/Urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants