-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix/icon ii #5413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/icon ii #5413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces icon padding from 200px to 50px (75% reduction) and increases the goose graphic scale from 3.0 to 3.5 to better fill the dock icon space. This eliminates the visible white border around the app icon on newer Macs. Changes: - Padding: 200px → 50px on all sides - Goose scale: 3.0 → 3.5 (16.7% larger) - Canvas usage: 80.5% → 95.1% - Position adjusted for better centering The fix aligns with Apple's dock icon guidelines while maintaining the Goose brand identity and rounded rectangle design.
- Created fix/iconII branch for Icon Composer icon integration - Analyzed Icon Composer project at /Users/spencermartin/Desktop/Gooseicon.icon - Confirmed SVG sources are identical to current versions - Icon Composer adds macOS-specific visual effects (glass, translucency, shadows) - Created backup of current images - Documented next steps for icon export and integration - Opened Xcode with Icon Composer project for manual export
- Integrated Icon Composer exported icons with macOS visual effects - Updated icon.icns (234K → 2.0M) with glass effect and translucency - Updated icon.png (64K → 1.6M) with enhanced rendering - Updated icon@2x.png (165K → 1.4M) for retina displays - Added visual effects: glass, 50% translucency, neutral shadow - Optimized for light/dark mode appearance - Created backups of old icons (.old files) - Documented changes in ICON_COMPARISON.md Source: Gooseicon-iOS-Default-1024x1024@1x.png from Icon Composer export Note: icon.ico unchanged (requires ImageMagick for regeneration)
- Use ClearLight variant as main icon (better for both light/dark modes) - Include icon-dark.icns and icon-dark.png for potential future dark mode support - Updated icon.icns (2.0M → 1.7M) with ClearLight variant - Updated icon.png (1.6M → 1.4M) with ClearLight variant - Updated icon@2x.png (1.4M → 960K) with proper 2x scaling Source: Gooseicon-iOS-ClearLight-1024x1024@1x.png from Icon Composer export
- Main icon now uses Gooseicon-iOS-Dark variant (better contrast) - icon.icns (2.0M) - Dark variant with glass effects - icon.png (1.6M) - Dark variant 1024x1024 - icon@2x.png (1.2M) - Dark variant 2048x2048 - Added icon-light.icns and icon-light.png for potential light mode support Source: Gooseicon-iOS-Dark-1024x1024@1x.png from Icon Composer export
- Small icon sizes (16x16, 32x32) now use modified SVG with less padding - Large icon sizes (128x128+) continue using Dark variant with full effects - This fixes the padding issue in Finder list view while keeping dock icon correct
- Switched from Dark variant to ClearDark variant - ClearDark has transparent background with no rounded rectangle - Consistent appearance across all sizes (dock and list view) - No padding/background in the design itself - Same icon used in dock now appears in list view Source: Gooseicon-iOS-ClearDark-1024x1024@1x.png from Icon Composer export
- Using Gooseicon-iOS-Dark for all sizes (16x16 through 1024x1024) - Full-bleed icon with rounded rectangle background (standard macOS style) - Includes Icon Composer glass effects and visual depth - Consistent appearance in dock, Finder, and list view - Matches design intent from Icon Composer export The rounded rectangle background is part of the icon design itself, not padding - this is the standard approach for macOS app icons.
Small sizes (16x16, 32x32): - Use ClearDark variant (no background, just goose) - Eliminates padding in Finder list view - Maximizes icon visibility at small sizes Large sizes (128x128+): - Use iOS Dark variant (full design with rounded rectangle) - Maintains polished appearance in dock and icon view - Includes Icon Composer glass effects This hybrid approach follows Apple's guideline that each icon size should be optimized for its display context, not just scaled.
- ALL sizes (16x16 through 1024x1024) use iOS Dark variant - Single consistent icon design throughout - No hybrid approach - one icon for all contexts - Goose on rounded rectangle background at all sizes This ensures complete consistency across dock, Finder, and list view.
macOS was loading a larger icon size and scaling it down, causing visible padding when it switched from initial load to final display. Solution: - 16x16, 32x32 (and @2x): Use ClearDark variant (no background) - Fills the icon space completely - No padding when macOS switches between sizes - 128x128+ sizes: Use iOS Dark variant (full design with background) - Maintains polished dock appearance This prevents the 'shrinking' effect you see when Finder switches from the initial icon to the retina/final version.
Removed all @2x retina versions from icon.icns to eliminate the switching/shrinking behavior in Finder list view. Icon now contains only 1x sizes: - 16x16 - 32x32 - 128x128 - 256x256 - 512x512 All using iOS Dark variant. macOS will use these sizes directly without switching between 1x and @2x versions.
zanesq
approved these changes
Oct 28, 2025
Collaborator
zanesq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified looks good locally
michaelneale
added a commit
that referenced
this pull request
Oct 29, 2025
* main: (30 commits) feat: add goose powered ai culinary innovation studio prompt to library (#5423) removing golang/temporal building testing tetrate with sonnet (#5428) Add Recipes Test Script (#5420) Don't die on strange chars (#5415) fix: allow subagent to run in parent --no-session mode (#5384) docs: analyze tool (#5418) fix: gracefully close goosed listening port (#5321) move history txt to state dir (#5410) Dont exit silently when storing api key fails (#5260) Make reply use the API (#5389) Fix/icon ii (#5413) Enable runtime access to provider name (#5399) fix: ensure trailing newline in files created by `text_editor` tool (#5336) docs: September 2025 Community All-Stars (#5411) make supports_cache_control async to avoid block in place (#5362) Send all the logs we output (#5363) Recipe variables (#5365) Feat/add mermaid chart rendering (#5377) Set up Datadog metrics for prompt injection detection (#5385) ...
katzdave
added a commit
that referenced
this pull request
Nov 3, 2025
* 'main' of github.com:block/goose: (132 commits) Fix/icon ii (#5413) Enable runtime access to provider name (#5399) fix: ensure trailing newline in files created by `text_editor` tool (#5336) docs: September 2025 Community All-Stars (#5411) make supports_cache_control async to avoid block in place (#5362) Send all the logs we output (#5363) Recipe variables (#5365) Feat/add mermaid chart rendering (#5377) Set up Datadog metrics for prompt injection detection (#5385) fix: restore --resume functionality for most recent session (#5401) Gemini again (#5390) docs(prompt-library): add github-issue-labeler intermediate prompt (#5374) docs: add Linux and Windows paths to uninstall section (#5371) fix: --session-id shouldn't work without --resume, but --name should (#5360) Auto-compact Threshold UI improvements (#5354) Filter preserved user messages to be text only. (#5391) include sessionId in tool request (#5394) feat: add PR Impact Analyzer prompt (#5375) docs: add blog post on configuring goose for team environments (#5380) migrating back with new chatrecall non underscore name (#5223) ...
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <Blairallan@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After:
Email: