Skip to content

Auto-compact Threshold UI improvements #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
katzdave merged 5 commits into from
Oct 27, 2025
Merged

Auto-compact Threshold UI improvements #5354

katzdave merged 5 commits into from
Oct 27, 2025

Conversation

@katzdave
Copy link
Collaborator

@katzdave katzdave commented Oct 24, 2025 •
edited
Loading

  • On the backend, don't treat disabled as 80%; disabled is off (but you can still compact with out of context error)

Client UI

  • Properly loads state in the context window so multiple windows stay in sync (it's a global shared config)
  • No longer has any UI around 'disabling it'. You can set it from 1-100%. Setting it to 100% still effectively disables auto-compact, but better communicates that your client will still compact itself if you run out of context. "Auto-compact at 100%"
  • Fix big threshold dots not showing up at some thresholds.
Screenshot 2025-10-24 at 1 18 44 PM

@katzdave katzdave requested a review from zanesq October 24, 2025 17:16
zanesq
zanesq approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@zanesq zanesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comment

crates/goose/src/context_mgmt/mod.rs Outdated

let needs_compaction = if threshold <= 0.0 || threshold >= 1.0 {
usage_ratio > DEFAULT_COMPACTION_THRESHOLD
false
Copy link
Collaborator

@zanesq zanesq Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit confusing to me, maybe a comment why we're disabling here?

@katzdave katzdave merged commit 77fe4f3 into main Oct 27, 2025
15 of 17 checks passed
@katzdave katzdave deleted the dkatz/auto-compact-threshold branch October 27, 2025 19:22
wpfleger96 added a commit that referenced this pull request Oct 27, 2025
@wpfleger96
Merge branch 'main' into wpfleger/session-name
a53c68e 
* main:
  Auto-compact Threshold UI improvements (#5354)
  Filter preserved user messages to be text only. (#5391)
  include sessionId in tool request (#5394)
  feat: add PR Impact Analyzer prompt (#5375)
  docs: add blog post on configuring goose for team environments (#5380)
  migrating back with new chatrecall non underscore name (#5223)
  fixing typo in blog metadata (#5382)
  feat: add new blog entry on adopting Goose in the enterprise (#5381)
  Blog/acp intro oct 2024 (#5379)
  feat: add A/B test framework generator recipe (#5378)
  Doc: (blog) - Deep Dive into goose's Extension System and Model Context Protocol (MCP) (#5291)
  Some system prompt tidying (#5313)
  Fix scheduler jobs dates formatting (#5368)
  Use Instructions as Prompt in Scheduler (#5359)
  feat(snowflake): add support for newer Claude 4.5 and 4 models (#5350)
wpfleger96 added a commit that referenced this pull request Oct 27, 2025
@wpfleger96
Merge branch 'main' into wpfleger/persist-provider-config
64e32cb 
* main:
  fix: --session-id shouldn't work without --resume, but --name should (#5360)
  Auto-compact Threshold UI improvements (#5354)
  Filter preserved user messages to be text only. (#5391)
  include sessionId in tool request (#5394)
michaelneale added a commit that referenced this pull request Oct 28, 2025
@michaelneale
Merge branch 'main' into micn/remove-go-temporal
bf7dcc5 
* main:
  Feat/add mermaid chart rendering (#5377)
  Set up Datadog metrics for prompt injection detection (#5385)
  fix: restore --resume functionality for most recent session (#5401)
  Gemini again (#5390)
  docs(prompt-library): add github-issue-labeler intermediate prompt (#5374)
  docs: add Linux and Windows paths to uninstall section (#5371)
  fix: --session-id shouldn't work without --resume, but --name should (#5360)
  Auto-compact Threshold UI improvements (#5354)
  Filter preserved user messages to be text only. (#5391)
  include sessionId in tool request (#5394)
  feat: add PR Impact Analyzer prompt (#5375)
  docs: add blog post on configuring goose for team environments (#5380)
  migrating back with new chatrecall non underscore name (#5223)
katzdave added a commit that referenced this pull request Nov 3, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into error-proxy-2
1fa40e0 
* 'main' of github.com:block/goose: (132 commits)
  Fix/icon ii (#5413)
  Enable runtime access to provider name (#5399)
  fix: ensure trailing newline in files created by `text_editor` tool (#5336)
  docs: September 2025 Community All-Stars (#5411)
  make supports_cache_control async to avoid block in place (#5362)
  Send all the logs we output (#5363)
  Recipe variables (#5365)
  Feat/add mermaid chart rendering (#5377)
  Set up Datadog metrics for prompt injection detection (#5385)
  fix: restore --resume functionality for most recent session (#5401)
  Gemini again (#5390)
  docs(prompt-library): add github-issue-labeler intermediate prompt (#5374)
  docs: add Linux and Windows paths to uninstall section (#5371)
  fix: --session-id shouldn't work without --resume, but --name should (#5360)
  Auto-compact Threshold UI improvements (#5354)
  Filter preserved user messages to be text only. (#5391)
  include sessionId in tool request (#5394)
  feat: add PR Impact Analyzer prompt (#5375)
  docs: add blog post on configuring goose for team environments (#5380)
  migrating back with new chatrecall non underscore name (#5223)
  ...
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Merged
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
@katzdave @BlairAllan
Auto-compact Threshold UI improvements (block#5354)
3123290 
Signed-off-by: Blair Allan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanesq zanesq zanesq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@katzdave @zanesq