Skip to content

Conversation

@michaelneale
Copy link
Collaborator

@michaelneale michaelneale commented Jan 3, 2025

to try:

export GOOSE_PROVIDER__TYPE="openrouter"
export GOOSE_PROVIDER__HOST="https://openrouter.ai"
export GOOSE_PROVIDER__MODEL="anthropic/claude-3.5-sonnet"
export GOOSE_PROVIDER__API_KEY=....

image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@michaelneale michaelneale marked this pull request as ready for review January 3, 2025 07:34
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@michaelneale michaelneale requested review from baxen and Copilot January 3, 2025 07:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@michaelneale michaelneale requested a review from Copilot January 6, 2025 03:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (3)
  • crates/goose/src/providers/configs.rs: Evaluated as low risk
  • crates/goose/src/providers/model_pricing.rs: Evaluated as low risk
  • crates/goose/src/providers.rs: Evaluated as low risk
Comments suppressed due to low confidence (1)

crates/goose-server/src/configuration.rs:189

  • [nitpick] The use of OpenAiProviderConfig for the OpenRouter provider might be confusing. Consider renaming OpenAiProviderConfig to a more generic name like ProviderConfig.
ProviderConfig::OpenRouter(OpenAiProviderConfig {

if let Some(err) = check_openai_context_length_error(error) {
return Err(err.into());
}
return Err(anyhow!("OpenRouter API error: {}", error));
Copy link

Copilot AI Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message 'OpenRouter API error: {}' is not very informative. Consider including more details from the error response to make debugging easier.

Suggested change
return Err(anyhow!("OpenRouter API error: {}", error));
return Err(anyhow!("OpenRouter API error: {}", error.get("message").unwrap_or(error)));

Copilot uses AI. Check for mistakes.

const DATABRICKS_CONFIG = `export GOOSE_PROVIDER__TYPE=databricks
export GOOSE_PROVIDER__HOST=your_databricks_host
export GOOSE_PROVIDER__MODEL=claude-3-sonnet-2`;
Copy link

Copilot AI Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Databricks configuration is missing the API_KEY environment variable. It should be added for consistency.

Suggested change
export GOOSE_PROVIDER__MODEL=claude-3-sonnet-2`;
export GOOSE_PROVIDER__API_KEY=your_api_key_here`;

Copilot uses AI. Check for mistakes.
defaultOpen?: boolean;
}

function Collapsible({ title, children, defaultOpen = false }: CollapsibleProps) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🥇, the only thing to add if possible is a copy to clipboard button in the top right to make it easier to copy paste the block

Copy link
Collaborator

@zakiali zakiali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out and works well!

Performance wasn't great, but the default anthropic model was claude 3 sonnnet, so that's why.. maybe we update the default to 3.5

@ahau-square
Copy link
Contributor

Nice! Tried it out with a few other models too - nvidia/llama-3.1-nemotron-70b-instruct for example works but deepseek/deepseek-chat does not (getting a 404 Not Found) though deepseek-chat is working in cline through openrouter

@michaelneale michaelneale merged commit 667187e into v1.0 Jan 6, 2025
6 checks passed
@michaelneale michaelneale deleted the micn/openrouter branch January 6, 2025 21:59
@ahau-square
Copy link
Contributor

Do we want to expose openrouter for CLI use as well?

michaelneale added a commit that referenced this pull request Jan 6, 2025
* v1.0: (43 commits)
  feat: openrouter provider (#538)
  [ui] chore: tidy up gui providers (#537)
  [ui]: Polish and system theme fix (#533)
  [ui]: General ui polish to more closely match designs (#532)
  Latency issue fix with prepare_inference (#535)
  chore: use cross to build binaries (#507)
  feat: a system for non developers to augment developer system (#524)
  fix: Broken open directory and new session buttons in more menu (#520)
  refactor: move get_usage to provider trait (#506)
  fix: Make stop button more obvious (#516)
  fix: Enhance Dark mode menu dots visibility (#517)
  working on automating release of .zip and binaries and having them on each PR as well (#509)
  conditionally load memory system in goose server (#508)
  Adds 'instructions' field to InitializeResult (#511)
  feat: MCP client sdk (#505)
  Update cli-release.yml
  feat: added groq provider (#494)
  fix: use rust tls (#500)
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
  ...
lily-de pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants