Skip to content

Conversation

@salman1993
Copy link
Contributor

Instructions describe how to use the server and its features - its part of the initialization phase
https://github.com/modelcontextprotocol/specification/blob/8008e38dc7180acdc95dc6762ea6b92a7976f174/schema/schema.ts#L175

in the protocol, instructions are optional but we make it required in this sdk

Copy link
Contributor

@kalvinnchau kalvinnchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salman1993 salman1993 merged commit 4db5ff7 into v1.0 Dec 20, 2024
3 checks passed
salman1993 added a commit that referenced this pull request Dec 20, 2024
* origin/v1.0:
  Adds 'instructions' field to InitializeResult (#511)
michaelneale added a commit that referenced this pull request Dec 21, 2024
* v1.0:
  conditionally load memory system in goose server (#508)
  Adds 'instructions' field to InitializeResult (#511)
  feat: MCP client sdk (#505)
michaelneale added a commit that referenced this pull request Jan 6, 2025
* v1.0: (43 commits)
  feat: openrouter provider (#538)
  [ui] chore: tidy up gui providers (#537)
  [ui]: Polish and system theme fix (#533)
  [ui]: General ui polish to more closely match designs (#532)
  Latency issue fix with prepare_inference (#535)
  chore: use cross to build binaries (#507)
  feat: a system for non developers to augment developer system (#524)
  fix: Broken open directory and new session buttons in more menu (#520)
  refactor: move get_usage to provider trait (#506)
  fix: Make stop button more obvious (#516)
  fix: Enhance Dark mode menu dots visibility (#517)
  working on automating release of .zip and binaries and having them on each PR as well (#509)
  conditionally load memory system in goose server (#508)
  Adds 'instructions' field to InitializeResult (#511)
  feat: MCP client sdk (#505)
  Update cli-release.yml
  feat: added groq provider (#494)
  fix: use rust tls (#500)
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
  ...
@yingjiehe-xyz yingjiehe-xyz deleted the sm/mcp-server-initparams branch February 5, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants