Skip to content

Conversation

@amed-xyz
Copy link
Collaborator

@amed-xyz amed-xyz commented Oct 6, 2025

Summary

Adds support for specifying http headers in extensions deeplinks. This works very similar to env vars.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

Testing

open a link such as

goose://extension?type=streamable_http&url=https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2F&id=github-mcp&name=GitHub&description=GitHub%20repository%20management%20and%20operations&header=Authorization%3Dyour%20token

@amed-xyz amed-xyz self-assigned this Oct 6, 2025
@amed-xyz amed-xyz requested a review from a team as a code owner October 6, 2025 17:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-10-06 23:05 UTC

</div>
)}

{server.headers && server.headers.length > 0 && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amed-xyz . I added similar support in a different PR but yours is cleaner so I'll rebase yours into my branch! I also hid the Environment Variables section in the details card for streamable http extension types. I can still plan to do that in my branch if you think that's a valid assumption.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, streamable http extensions would only show a Request Headers section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dianed-square thanks for the review! I'm not sure if there's valid cases for a streamable http extension to have env vars, maybe @blackgirlbytes would more about it!

Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

name: string;
description: string;
required: boolean;
}[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the MCPServer type used across the extensions section

@amed-xyz amed-xyz merged commit d41e32a into main Oct 6, 2025
12 checks passed
@amed-xyz amed-xyz deleted the amed/deeplink-header-support branch October 6, 2025 23:03
lifeizhou-ap added a commit that referenced this pull request Oct 7, 2025
* main:
  use agent manager for subagent (#4828)
  fix: improve Windows OS detection in CLI installation script (#4928)
  Make it startable from playwright and also isolate (#5016)
  Fix linux deeplinks not working (#5041)
  docs: embed more videos (#5042)
  Display extension install notes in "Add custom extension" form (#5036)
  Add support for headers in extensions deeplinks (#5034)
  chore: put test in the name (#4919)
  Add new subcommand for opening recipes in desktop app (#4970)
  Update system.md with softer subagent language (#5023)
  docs: add new goose tip (#4941)
  Fix nix flake double copy (#4976)
  Upgrade electron for macOS Tahoe compatibility (#5015)
Itz-Agasta pushed a commit to Itz-Agasta/goose that referenced this pull request Oct 7, 2025
ARYPROGRAMMER pushed a commit to ARYPROGRAMMER/goose that referenced this pull request Oct 7, 2025
dianed-square pushed a commit that referenced this pull request Oct 7, 2025
katzdave added a commit that referenced this pull request Oct 7, 2025
…aned-tool-calls

* 'main' of github.com:block/goose: (38 commits)
  docs: misc updates for extensions directory (#5035)
  updating recipe scanner workflows for detecting recipes from forked repos (#5056)
  feat(prompt-library): add Smart Meeting Assistant advanced prompt (#4998) (#5031)
  Allow auto focus and typing while chat is initializing (#5043)
  docs(blog): Add blog for running Goose in containerized envs  (#5052)
  fix: Add WINDOWS_CODESIGN_CERTIFICATE to nightly workflow (#5037)
  Developer `analyze` tool improvement (#5030)
  use agent manager for subagent (#4828)
  fix: improve Windows OS detection in CLI installation script (#4928)
  Make it startable from playwright and also isolate (#5016)
  Fix linux deeplinks not working (#5041)
  docs: embed more videos (#5042)
  Display extension install notes in "Add custom extension" form (#5036)
  Add support for headers in extensions deeplinks (#5034)
  chore: put test in the name (#4919)
  Add new subcommand for opening recipes in desktop app (#4970)
  Update system.md with softer subagent language (#5023)
  docs: add new goose tip (#4941)
  Fix nix flake double copy (#4976)
  Upgrade electron for macOS Tahoe compatibility (#5015)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants