Skip to content

Conversation

@yingjiehe-xyz
Copy link
Contributor

@yingjiehe-xyz yingjiehe-xyz commented Sep 25, 2025

Pull Request Description

Use the agent manager added in #4684 for the subagent task execution

Test:

( O)> use the subagent to summarize my slacks channels g2-help

I'll use a subagent to summarize your Slack channel `g2-help`. Let me create a task for this.
─── create_task | dynamic_task ──────────────────────────
task_parameters:
    -
        instructions: Summarize the Slack channel 'g2-help'. Get recent messages from this channel and provide a comprehensive summary of the discussions, key topics, common issues, and any important information shared. Focus on the most recent activity and highlight any recurring themes or important announcements.
        title: Summarize g2-help Slack Channel
        extensions:
            - slack
        return_last_only: true


─── execute_task | subagent ──────────────────────────
task_ids: 1a070d51-3d2d-4f57-8c19-cad83b66418d

# Summary of G2-Help Slack Channel

Based on the recent messages from the **g2-help** channel, here's a comprehensive summary of the discussions, key topics, and common issues:

## **Key Topics & Recurring Themes**

### **1. Integration Requests & MCP Extensions**
- **Zendesk Integration**: Request for Zendesk integration for Bitkey's customer service management
- **Sentry Integration**: On the roadmap and being prioritized
- **Salesforce & Looker**: Targeting Q4 for Salesforce, working on timeline for Looker
- **Square Wise Integration**: Request for technical teams integration
- **Multiple Notion Spaces**: Users want ability to connect to multiple Notion workspaces simultaneously

### **2. Technical Issues & Troubleshooting**

#### **Context Limit Errors**
- Users experiencing "conversation has exceeded the model's context limit" errors
- **Solution**: Start a new session to reset token count
- Progress bar shows token usage during chat sessions
- Future context summarization feature planned

#### **Google Calendar SSL Issues**
- SSL/TLS connection failures when connecting to Google Calendar API
- Error: `[SSL] record layer failure (_ssl.c:2580)`
- Issue appears intermittent and may resolve on its own

......

@yingjiehe-xyz yingjiehe-xyz marked this pull request as ready for review September 25, 2025 19:22
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some preliminary questions but like the deleting

@yingjiehe-xyz yingjiehe-xyz force-pushed the yingjiehe/test branch 2 times, most recently from cbfa39f to 88b0dd6 Compare September 29, 2025 20:27
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty decent, but I think we need to tighten up the typing here and make the compiler our friend.

my main concern here is how we run the agent here. we have a parent_id but we're not doing all that much with it. the TaskConfig has a provider and a parent_id and the provider is the provider of the parent. maybe it should copy that on instantiation? same for working_dir I think. extensions is set separately again, but I feel like this should sometimes default to whatever the agent had at the time? like if you run a subrecipe where you don't specify extensions

@yingjiehe-xyz
Copy link
Contributor Author

this looks pretty decent, but I think we need to tighten up the typing here and make the compiler our friend.

my main concern here is how we run the agent here. we have a parent_id but we're not doing all that much with it. the TaskConfig has a provider and a parent_id and the provider is the provider of the parent. maybe it should copy that on instantiation? same for working_dir I think. extensions is set separately again, but I feel like this should sometimes default to whatever the agent had at the time? like if you run a subrecipe where you don't specify extensions

for the extension, I think it would be better to start with specified extension to reduce the prompt length and keep it consistent with recipe

@DOsinga
Copy link
Collaborator

DOsinga commented Sep 30, 2025

for the extension, I think it would be better to start with specified extension to reduce the prompt length and keep it consistent with recipe

sorry, but that is not how I read the code. I think we ask the AI to generate a spec to run with an empty list for extensions for no extensions and none for inheriting the extensions. /cc @tlongwell-block

@tlongwell-block
Copy link
Collaborator

tlongwell-block commented Sep 30, 2025

for the extension, I think it would be better to start with specified extension to reduce the prompt length and keep it consistent with recipe

sorry, but that is not how I read the code. I think we ask the AI to generate a spec to run with an empty list for extensions for no extensions and none for inheriting the extensions. /cc @tlongwell-block

Right now, if the parent agent does not specify the extensions parameter, the subagent it creates gets all of the same extensions as the parent agent

If the parent agent specifies an empty extensions parameter, the subagent it creates gets no extensions

@tlongwell-block
Copy link
Collaborator

─── create_task | dynamic_task ──────────────────────────
task_parameters:
    -
        title: Test 4a: Weather
        instructions: Tell me a fun fact about weather
        return_last_only: true
    -
        title: Test 4b: Joke
        instructions: Tell me a knock-knock joke
        return_last_only: true


─── execute_task | subagent ──────────────────────────
task_ids: 87641b31-7d63-4081-95cf-6c5e957f5f3e, e8b0b3ed-a30a-4174-b521-636e95ab49fc
execution_mode: parallel


🎯 Task Execution Dashboard
═══════════════════════════

📊 Progress: 2 total | ⏳ 0 pending | 🏃 0 running | ✅ 1 completed | ❌ 1 failed

❌ 87641b31-7d63-4081-95cf-6c5e957f5f3e (inline_recipe)
   ⏱️  0.0s
   ⚠️  Inline recipe execution failed: -32603: Failed to execute task: Failed to cre...

✅ e8b0b3ed-a30a-4174-b521-636e95ab49fc (inline_recipe)
   ⏱️  4.0s
   📄 {
  "result": "Here's a knock-knock joke for you:\n\nKnock, knock.  \nWho's there?  \nInterrupting cow.  \nInterrupting cow w—  \n**MOOOOO!**\n\n😄 The joke works because the cow interrupts before you can finish saying \"who?\""
}

Execution Complete!
═══════════════════════
Total Tasks: 2
✅ Completed: 1
❌ Failed: 1
📈 Success Rate: 50.0%

❌ Failed Tasks:
   • 87641b31-7d63-4081-95cf-6c5e957f5f3e
     Error: Inline recipe execution failed: -32603: Failed to execute task: Failed to create a session for sub agent: error returned from database: (code: 5) database is locked

📝 Generating summary...
-32603: 1/2 tasks failed:
Task '87641b31-7d63-4081-95cf-6c5e957f5f3e' (ID: 87641b31-7d63-4081-95cf-6c5e957f5f3e): Inline recipe execution failed: -32603: Failed to execute task: Failed to create a session for sub agent: error returned from database: (code: 5) database is locked

Output: No output captured

Interesting! We hit a database locking issue with parallel execution. Let me update the TODO and retry:

@DOsinga
Copy link
Collaborator

DOsinga commented Oct 2, 2025

also let me know @yingjiehe-xyz when you want me to have another look

@yingjiehe-xyz
Copy link
Contributor Author

also let me know @yingjiehe-xyz when you want me to have another look

yes, I think it should be ready for the review

@yingjiehe-xyz yingjiehe-xyz requested a review from DOsinga October 7, 2025 00:52
@yingjiehe-xyz yingjiehe-xyz merged commit 0600cb4 into main Oct 7, 2025
11 checks passed
@yingjiehe-xyz yingjiehe-xyz deleted the yingjiehe/test branch October 7, 2025 04:17
lifeizhou-ap added a commit that referenced this pull request Oct 7, 2025
* main:
  use agent manager for subagent (#4828)
  fix: improve Windows OS detection in CLI installation script (#4928)
  Make it startable from playwright and also isolate (#5016)
  Fix linux deeplinks not working (#5041)
  docs: embed more videos (#5042)
  Display extension install notes in "Add custom extension" form (#5036)
  Add support for headers in extensions deeplinks (#5034)
  chore: put test in the name (#4919)
  Add new subcommand for opening recipes in desktop app (#4970)
  Update system.md with softer subagent language (#5023)
  docs: add new goose tip (#4941)
  Fix nix flake double copy (#4976)
  Upgrade electron for macOS Tahoe compatibility (#5015)
Itz-Agasta pushed a commit to Itz-Agasta/goose that referenced this pull request Oct 7, 2025
ARYPROGRAMMER pushed a commit to ARYPROGRAMMER/goose that referenced this pull request Oct 7, 2025
katzdave added a commit that referenced this pull request Oct 7, 2025
…aned-tool-calls

* 'main' of github.com:block/goose: (38 commits)
  docs: misc updates for extensions directory (#5035)
  updating recipe scanner workflows for detecting recipes from forked repos (#5056)
  feat(prompt-library): add Smart Meeting Assistant advanced prompt (#4998) (#5031)
  Allow auto focus and typing while chat is initializing (#5043)
  docs(blog): Add blog for running Goose in containerized envs  (#5052)
  fix: Add WINDOWS_CODESIGN_CERTIFICATE to nightly workflow (#5037)
  Developer `analyze` tool improvement (#5030)
  use agent manager for subagent (#4828)
  fix: improve Windows OS detection in CLI installation script (#4928)
  Make it startable from playwright and also isolate (#5016)
  Fix linux deeplinks not working (#5041)
  docs: embed more videos (#5042)
  Display extension install notes in "Add custom extension" form (#5036)
  Add support for headers in extensions deeplinks (#5034)
  chore: put test in the name (#4919)
  Add new subcommand for opening recipes in desktop app (#4970)
  Update system.md with softer subagent language (#5023)
  docs: add new goose tip (#4941)
  Fix nix flake double copy (#4976)
  Upgrade electron for macOS Tahoe compatibility (#5015)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants