-
Notifications
You must be signed in to change notification settings - Fork 2.4k
use agent manager for subagent #4828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DOsinga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some preliminary questions but like the deleting
cbfa39f to
88b0dd6
Compare
DOsinga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty decent, but I think we need to tighten up the typing here and make the compiler our friend.
my main concern here is how we run the agent here. we have a parent_id but we're not doing all that much with it. the TaskConfig has a provider and a parent_id and the provider is the provider of the parent. maybe it should copy that on instantiation? same for working_dir I think. extensions is set separately again, but I feel like this should sometimes default to whatever the agent had at the time? like if you run a subrecipe where you don't specify extensions
c03e7a2 to
e703602
Compare
for the extension, I think it would be better to start with specified extension to reduce the prompt length and keep it consistent with recipe |
sorry, but that is not how I read the code. I think we ask the AI to generate a spec to run with an empty list for extensions for no extensions and none for inheriting the extensions. /cc @tlongwell-block |
Right now, if the parent agent does not specify the If the parent agent specifies an empty |
2757b59 to
da5f658
Compare
|
|
also let me know @yingjiehe-xyz when you want me to have another look |
yes, I think it should be ready for the review |
ce3af2d to
17602e9
Compare
* main: use agent manager for subagent (#4828) fix: improve Windows OS detection in CLI installation script (#4928) Make it startable from playwright and also isolate (#5016) Fix linux deeplinks not working (#5041) docs: embed more videos (#5042) Display extension install notes in "Add custom extension" form (#5036) Add support for headers in extensions deeplinks (#5034) chore: put test in the name (#4919) Add new subcommand for opening recipes in desktop app (#4970) Update system.md with softer subagent language (#5023) docs: add new goose tip (#4941) Fix nix flake double copy (#4976) Upgrade electron for macOS Tahoe compatibility (#5015)
Signed-off-by: Itz-Agasta <[email protected]>
Signed-off-by: Arya Pratap Singh <[email protected]>
…aned-tool-calls * 'main' of github.com:block/goose: (38 commits) docs: misc updates for extensions directory (#5035) updating recipe scanner workflows for detecting recipes from forked repos (#5056) feat(prompt-library): add Smart Meeting Assistant advanced prompt (#4998) (#5031) Allow auto focus and typing while chat is initializing (#5043) docs(blog): Add blog for running Goose in containerized envs (#5052) fix: Add WINDOWS_CODESIGN_CERTIFICATE to nightly workflow (#5037) Developer `analyze` tool improvement (#5030) use agent manager for subagent (#4828) fix: improve Windows OS detection in CLI installation script (#4928) Make it startable from playwright and also isolate (#5016) Fix linux deeplinks not working (#5041) docs: embed more videos (#5042) Display extension install notes in "Add custom extension" form (#5036) Add support for headers in extensions deeplinks (#5034) chore: put test in the name (#4919) Add new subcommand for opening recipes in desktop app (#4970) Update system.md with softer subagent language (#5023) docs: add new goose tip (#4941) Fix nix flake double copy (#4976) Upgrade electron for macOS Tahoe compatibility (#5015) ...
Pull Request Description
Use the agent manager added in #4684 for the subagent task execution
Test: