-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: Issue #4540: goose configure -> Cursor Agent succeeds
#4942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue #4540: goose configure -> Cursor Agent succeeds
#4942
Conversation
|
thanks @ElectricToy do you mind doing the DCO thing so commits are ok? |
f74c865 to
1f52068
Compare
|
@michaelneale no problem, done. |
| pub const CURSOR_AGENT_DEFAULT_MODEL: &str = "gpt-5"; | ||
| pub const CURSOR_AGENT_KNOWN_MODELS: &[&str] = &["gpt-5", "opus-4.1", "sonnet-4"]; | ||
| pub const CURSOR_AGENT_DEFAULT_MODEL: &str = "auto"; | ||
| pub const CURSOR_AGENT_KNOWN_MODELS: &[&str] = &["auto", "gpt-5", "opus-4.1", "sonnet-4", "claude"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why we're adding claude here. does it work with goose already and was simply missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
claude-agent (at least here) lists it as an available model, perhaps as a proxy for a self-selecting sonnet version? I can't verify that it works with goose yet, though, because I haven't been able to get goose to work with any model yet (hence the attempted bug fix). Because goose is not yet querying cursor-agent models and won't present this as an option for users, its presence here will do no harm, but I'll amend it out until I can verify that goose can talk to cursor-agent this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay @loganblevins, that's amended. Good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I don't have write access to stamp this however. Feel free to open for review and our maintainers can take a peek I'm sure 😄
1f52068 to
a03670a
Compare
…uration to continue Signed-off-by: Jeff Wofford <[email protected]>
a03670a to
c64f755
Compare
|
thanks @ElectricToy ! |
* main: (22 commits) fix: Issue #4540: `goose configure` -> Cursor Agent succeeds (#4942) feat: Add advanced data analysis pipeline recipe (#4990) (#5005) Create / edit recipe form unification and improvements (#4693) feat: add Code Review Mentor recipe with Developer and Memory extensions (#4992) (#5014) feat: set custom models for lead/worker (#4598) feat: add grok-code-fast-1 support for xAI provider (#4472) Persist dynamic extension config so we can resume recipe sessions w/ extensions (#4331) fix: show PowerShell PATH instructions for Windows users (#4989) feat: add Smart Task Organizer recipe for Hacktoberfest (#4936) Fix extension headers (#5000) feat: add advanced software project generator initializer recipe (#4767) (#4949) Removed unused libs (#4932) Platform extensions sketch (#4868) Add reply to the routes (#4963) feat(cli): add GOOSE_DEBUG environment variable support (#4825) docs: Change community page sections (#4984) docs: remove temporary Hacktoberfest issue templates (#4982) Create multi-channel researcher prompt (#4947) docs: Add Community Content section to Community Page (#4964) Allow empty API Key when registering custom provider (#4977) ...
* main: (130 commits) Add new subcommand for opening recipes in desktop app (block#4970) Update system.md with softer subagent language (block#5023) docs: add new goose tip (block#4941) Fix nix flake double copy (block#4976) Upgrade electron for macOS Tahoe compatibility (block#5015) fix: check server is ready so that we can decode the recipe deeplink (block#5021) fix: backwards compatible parsing recipe file (block#5020) chore: Used common function to list recipes in local machine (block#4974) fix: Issue block#4540: `goose configure` -> Cursor Agent succeeds (block#4942) feat: Add advanced data analysis pipeline recipe (block#4990) (block#5005) Create / edit recipe form unification and improvements (block#4693) feat: add Code Review Mentor recipe with Developer and Memory extensions (block#4992) (block#5014) feat: set custom models for lead/worker (block#4598) feat: add grok-code-fast-1 support for xAI provider (block#4472) Persist dynamic extension config so we can resume recipe sessions w/ extensions (block#4331) fix: show PowerShell PATH instructions for Windows users (block#4989) feat: add Smart Task Organizer recipe for Hacktoberfest (block#4936) Fix extension headers (block#5000) feat: add advanced software project generator initializer recipe (block#4767) (block#4949) Removed unused libs (block#4932) ...
…ock#4942) Signed-off-by: Jeff Wofford <[email protected]> Signed-off-by: Itz-Agasta <[email protected]>
Pull Request Description
As described in issue #4540, on Mac (at least) the Cursor Agent provider could not be configured via
goose configurebecause the process failed with error:This was not (at least in my case) a permissions error, but a result of two difficulties with cursor-agent's model parameter.
First, for some reason the documented "-m" argument to
cursor-agentdoes not work in current versions; the full "--model" form must be used.Second, "gpt-5" was not recognized as a valid by
cursor-agent(at least on my system, though the model is certainly available and listed under certain circumstances). Goose does not yet seem to implement real-time model enumeration forcursor-agent, so the quick fix is to use "auto" as the default. In effect, replacing the command arguments "-m gpt-5" with "--model auto" enables configuration to successfully conclude.