Skip to content

Conversation

@kamal
Copy link
Contributor

@kamal kamal commented Sep 10, 2025

Pull Request Description

This PR adds the ability to set a custom model ID for lead and/or worker.

Screenshot 2025-09-10 at 10 54 03 AM

Long term, would it be more consistent to use the Provider -> Model components as seen in the Switch Model modal?

@kamal kamal force-pushed the custom-lead-worker-models branch from b2f883b to 1bbff98 Compare September 10, 2025 17:53
@DOsinga
Copy link
Collaborator

DOsinga commented Sep 29, 2025

I'm sorry, I thought I had replied to this. what does the custom model mean here, are you trying to enable having different models from different providers and doing that through a composable string?

@DOsinga DOsinga self-assigned this Sep 29, 2025
@kamal
Copy link
Contributor Author

kamal commented Sep 29, 2025

@DOsinga this modal only allows you to choose from the dropdown of models declared by each provider that you've connected. However, there's always been a way to provide your own model ID that is not listed in the dropdown. Take for example the AWS Bedrock provider. The switch model modal only lists Sonnet 3.5, but it allows you to set a custom model. With this PR, I'm extending that capability to the lead/worker modal.

Screenshot 2025-09-29 at 9 45 48 AM

@DOsinga
Copy link
Collaborator

DOsinga commented Sep 30, 2025

@DOsinga this modal only allows you to choose from the dropdown of models declared by each provider that you've connected. However, there's always been a way to provide your own model ID that is not listed in the dropdown. Take for example the AWS Bedrock provider. The switch model modal only lists Sonnet 3.5, but it allows you to set a custom model. With this PR, I'm extending that capability to the lead/worker modal.

Screenshot 2025-09-29 at 9 45 48 AM

well, I didn't know that. maybe we can do a quick follow up where we reuse the entire provider/model selector thing?

@kamal
Copy link
Contributor Author

kamal commented Sep 30, 2025

@DOsinga i'm going to rebase this against latest so that the CI github action will run now that you've approved it

Signed-off-by: Kamal Fariz Mahyuddin <[email protected]>
@kamal kamal force-pushed the custom-lead-worker-models branch from 1bbff98 to 6d9f071 Compare September 30, 2025 17:07
@kamal
Copy link
Contributor Author

kamal commented Sep 30, 2025

@DOsinga looks like you'll have to approve the workflows to run

@DOsinga
Copy link
Collaborator

DOsinga commented Oct 2, 2025

sorry this is annoying

@DOsinga DOsinga merged commit 9e9495e into block:main Oct 4, 2025
10 checks passed
zanesq added a commit that referenced this pull request Oct 4, 2025
…-unification

* 'main' of github.com:block/goose:
  feat: set custom models for lead/worker (#4598)
  feat: add grok-code-fast-1 support for xAI provider (#4472)
  Persist dynamic extension config so we can resume recipe sessions w/ extensions (#4331)
  fix: show PowerShell PATH instructions for Windows users (#4989)
  feat: add Smart Task Organizer recipe for Hacktoberfest (#4936)
  Fix extension headers (#5000)
  feat: add advanced software project generator initializer recipe (#4767) (#4949)
lifeizhou-ap added a commit that referenced this pull request Oct 6, 2025
* main: (22 commits)
  fix: Issue #4540: `goose configure` -> Cursor Agent succeeds (#4942)
  feat: Add advanced data analysis pipeline recipe (#4990) (#5005)
  Create / edit recipe form unification and improvements (#4693)
  feat: add Code Review Mentor recipe with Developer and Memory extensions (#4992) (#5014)
  feat: set custom models for lead/worker (#4598)
  feat: add grok-code-fast-1 support for xAI provider (#4472)
  Persist dynamic extension config so we can resume recipe sessions w/ extensions (#4331)
  fix: show PowerShell PATH instructions for Windows users (#4989)
  feat: add Smart Task Organizer recipe for Hacktoberfest (#4936)
  Fix extension headers (#5000)
  feat: add advanced software project generator initializer recipe (#4767) (#4949)
  Removed unused libs (#4932)
  Platform extensions sketch (#4868)
  Add reply to the routes (#4963)
  feat(cli): add GOOSE_DEBUG environment variable support (#4825)
  docs: Change community page sections (#4984)
  docs: remove temporary Hacktoberfest issue templates (#4982)
  Create multi-channel researcher prompt (#4947)
  docs: Add Community Content section to Community Page (#4964)
  Allow empty API Key when registering custom provider (#4977)
  ...
wpfleger96 added a commit to wpfleger96/goose that referenced this pull request Oct 6, 2025
* main: (130 commits)
  Add new subcommand for opening recipes in desktop app (block#4970)
  Update system.md with softer subagent language (block#5023)
  docs: add new goose tip (block#4941)
  Fix nix flake double copy (block#4976)
  Upgrade electron for macOS Tahoe compatibility (block#5015)
  fix: check server is ready so that we can decode the recipe deeplink (block#5021)
  fix: backwards compatible parsing recipe file (block#5020)
  chore: Used common function to list recipes in local machine (block#4974)
  fix: Issue block#4540: `goose configure` -> Cursor Agent succeeds (block#4942)
  feat: Add advanced data analysis pipeline recipe (block#4990) (block#5005)
  Create / edit recipe form unification and improvements (block#4693)
  feat: add Code Review Mentor recipe with Developer and Memory extensions (block#4992) (block#5014)
  feat: set custom models for lead/worker (block#4598)
  feat: add grok-code-fast-1 support for xAI provider (block#4472)
  Persist dynamic extension config so we can resume recipe sessions w/ extensions (block#4331)
  fix: show PowerShell PATH instructions for Windows users (block#4989)
  feat: add Smart Task Organizer recipe for Hacktoberfest (block#4936)
  Fix extension headers (block#5000)
  feat: add advanced software project generator initializer recipe (block#4767) (block#4949)
  Removed unused libs (block#4932)
  ...
Itz-Agasta pushed a commit to Itz-Agasta/goose that referenced this pull request Oct 7, 2025
Signed-off-by: Kamal Fariz Mahyuddin <[email protected]>
Signed-off-by: Itz-Agasta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants