-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix redirect to extensions page after deeplink install and show toast with success message #4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… with success message
ui/desktop/src/App.tsx
Outdated
| const [didSelectProvider, setDidSelectProvider] = useState<boolean>(false); | ||
|
|
||
| const navigate = useNavigate(); | ||
| const setView = useMemo(() => createNavigationHandler(navigate), [navigate]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have this pattern N times now, we can probably do something less repetitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done but added your favorite a new hook unless you have better ideas
| console.log('Environment variables or headers required, redirecting to extensions'); | ||
| console.log('Calling setView with:', { deepLinkConfig: config, showEnvVars: true }); | ||
| setView('settings', { deepLinkConfig: config, showEnvVars: true }); | ||
| setView('extensions', { deepLinkConfig: config, showEnvVars: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're now going to extensions whether you had this set or no. but in the second case we provide the extensionId. what's the difference? and also can we unify the two paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, should probably send extensionId in both cases will update 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use the name from deepLinkConfig instead of passing extensionId separately since thats what extensionId was anyway :) not sure what you meant by unify the paths, in this case it returns after because it doesn't need to call addExtensionFn and the toast message is shown after the modal installation in this case
…-deeplink * 'main' of github.com:block/goose: (57 commits) Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901) fix mcp integration test flakiness (#4871) Add type field to empty schemas for anthropic (#4911) docs: remove subagents from experimental (#4907) CLI: dont show logs to user (#4902) patching the security scanner to redact environment variables (#4908) rmcp upgrade (#4792) feat: Use the screen, goose (#4905) added claude-sonnet-4-5 (#4906) Tiny: fix github casing (#4903) remove anyOf from create_task tool (#4897) chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 (#4442) ...
* main: (30 commits) feat(nightly): build nightlies from main shas (block#4888) Add missing library for fedora/rhel/centos docs (block#4819) feat(process): Add GOVERNANCE and MAINTAINERS documents (block#4962) Pause test finder, have it run cargo fmt (block#4958) Disable the issue comment trigger on pr-comment-bundle (block#4961) fix(providers): update Claude Sonnet 4 model identifier (block#4884) fix redirect to extensions page after deeplink install and show toast with success message (block#4863) Remove wait-for-ready log (block#4956) docs: add a new goose tip (block#4940) Add PR template (block#4934) Using --resume with --name should still accept session IDs (block#4937) Fix auto scroll to bottom during chat (block#4923) Fix Typo, Add Description to Hacktoberfest Content Issue Template (block#4931) Don't set agent props twice (block#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (block#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (block#4913) feat: lazy infinite scroller for session history view (block#4922) chore: properly identify when to try oauth (block#4918) Make token counter safer (block#4924) ...
…se into zane/create-recipe-unification-feedback * 'zane/create-recipe-unification' of github.com:block/goose: feat(nightly): build nightlies from main shas (#4888) Add missing library for fedora/rhel/centos docs (#4819) feat(process): Add GOVERNANCE and MAINTAINERS documents (#4962) Pause test finder, have it run cargo fmt (#4958) Disable the issue comment trigger on pr-comment-bundle (#4961) fix(providers): update Claude Sonnet 4 model identifier (#4884) fix redirect to extensions page after deeplink install and show toast with success message (#4863) Remove wait-for-ready log (#4956)
* main: (24 commits) Lifei/create save recipe to file (#4895) feat(nightly): build nightlies from main shas (#4888) Add missing library for fedora/rhel/centos docs (#4819) feat(process): Add GOVERNANCE and MAINTAINERS documents (#4962) Pause test finder, have it run cargo fmt (#4958) Disable the issue comment trigger on pr-comment-bundle (#4961) fix(providers): update Claude Sonnet 4 model identifier (#4884) fix redirect to extensions page after deeplink install and show toast with success message (#4863) Remove wait-for-ready log (#4956) docs: add a new goose tip (#4940) Add PR template (#4934) Using --resume with --name should still accept session IDs (#4937) Fix auto scroll to bottom during chat (#4923) Fix Typo, Add Description to Hacktoberfest Content Issue Template (#4931) Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) ...
… with success message (block#4863) Co-authored-by: Amed Rodriguez <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
… with success message (#4863) Co-authored-by: Amed Rodriguez <[email protected]> # Conflicts: # ui/desktop/src/components/settings/extensions/ExtensionsSection.tsx # ui/desktop/src/components/settings/extensions/deeplink.ts
…orphaned-tool-calls * 'release/1.9.2' of github.com:block/goose: Fix auto scroll to bottom during chat (#4923) fix redirect to extensions page after deeplink install and show toast with success message (#4863) added claude-sonnet-4-5 (#4906) Upgrade electron for macOS Tahoe compatibility (#5015) chore(release): release version 1.9.2
Noticed extension deeplinks weren't redirecting to the extensions page. Also noticed that the extension is not automatically activated simply by going back to chat route and only activated in a completely new session so we need to address that.
For now I added a toast with more info to start a completely new session to activate the extension. I also considered not enabling the extension and letting the user activate it manually but that adds another step.
NOTE: there is an issue currently where refreshing the app after installing from a deeplink starts the deeplink again (same with recipe deeplinks) we should follow up and fix that in another PR