Include Session ID appropriately in UI #4901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update App.tsx to propagate session ID globally after loadCurrentChat - Add sessionId parameter to context management functions - Wrap ExtensionsRoute in ChatProvider for session access - Update tests to include sessionId parameter - Make sessionId optional in handleManualCompaction for backward compatibility This ensures: 1. First message has valid session ID (no 'Session not found' error) 2. Extensions can be activated with proper session ID 3. Context compaction includes required sessionId field
…rameters - Remove duplicate sessionId property in test expectation - Add missing sessionId parameter to handleManualCompaction test calls
alexhancock
approved these changes
Oct 1, 2025
katzdave
added a commit
that referenced
this pull request
Oct 1, 2025
* 'main' of github.com:block/goose: fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901)
zanesq
added a commit
that referenced
this pull request
Oct 1, 2025
…-deeplink * 'main' of github.com:block/goose: (57 commits) Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901) fix mcp integration test flakiness (#4871) Add type field to empty schemas for anthropic (#4911) docs: remove subagents from experimental (#4907) CLI: dont show logs to user (#4902) patching the security scanner to redact environment variables (#4908) rmcp upgrade (#4792) feat: Use the screen, goose (#4905) added claude-sonnet-4-5 (#4906) Tiny: fix github casing (#4903) remove anyOf from create_task tool (#4897) chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 (#4442) ...
zanesq
added a commit
that referenced
this pull request
Oct 1, 2025
* 'main' of github.com:block/goose: Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901) fix mcp integration test flakiness (#4871) Add type field to empty schemas for anthropic (#4911) docs: remove subagents from experimental (#4907) CLI: dont show logs to user (#4902) patching the security scanner to redact environment variables (#4908) rmcp upgrade (#4792) feat: Use the screen, goose (#4905) # Conflicts: # ui/desktop/src/components/ui/scroll-area.tsx
michaelneale
added a commit
that referenced
this pull request
Oct 2, 2025
* main: Fix auto scroll to bottom during chat (#4923) Fix Typo, Add Description to Hacktoberfest Content Issue Template (#4931) Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901) fix mcp integration test flakiness (#4871)
michaelneale
added a commit
that referenced
this pull request
Oct 2, 2025
* main: (44 commits) Add PR template (#4934) Using --resume with --name should still accept session IDs (#4937) Fix auto scroll to bottom during chat (#4923) Fix Typo, Add Description to Hacktoberfest Content Issue Template (#4931) Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901) fix mcp integration test flakiness (#4871) Add type field to empty schemas for anthropic (#4911) docs: remove subagents from experimental (#4907) CLI: dont show logs to user (#4902) patching the security scanner to redact environment variables (#4908) rmcp upgrade (#4792) feat: Use the screen, goose (#4905) ...
zanesq
added a commit
that referenced
this pull request
Oct 2, 2025
…-unification * 'main' of github.com:block/goose: (24 commits) Fix auto scroll to bottom during chat (#4923) Fix Typo, Add Description to Hacktoberfest Content Issue Template (#4931) Don't set agent props twice (#4872) fix: conversation fixer merges assistant text blocks and drops empty text messages (#4898) Batch fetch remaining issues for documentation updates fix: session timestamps (#4913) feat: lazy infinite scroller for session history view (#4922) chore: properly identify when to try oauth (#4918) Make token counter safer (#4924) Rename Hacktoberfest Blog to Hacktoberfest Content (#4926) Include Session ID appropriately in UI (#4901) fix mcp integration test flakiness (#4871) Add type field to empty schemas for anthropic (#4911) docs: remove subagents from experimental (#4907) CLI: dont show logs to user (#4902) patching the security scanner to redact environment variables (#4908) rmcp upgrade (#4792) feat: Use the screen, goose (#4905) added claude-sonnet-4-5 (#4906) Tiny: fix github casing (#4903) ... # Conflicts: # ui/desktop/src/components/BaseChat.tsx
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4899