-
Notifications
You must be signed in to change notification settings - Fork 2.6k
improve auto scroll to bottom + detection #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
.bundle |
macOS ARM64 Desktop App (Apple Silicon)📱 Download macOS Desktop App (arm64, unsigned) Instructions: |
| if (scrollRef.current?.scrollToBottom) { | ||
| scrollRef.current.scrollToBottom(); | ||
| } | ||
| }, 500); // delay to ensure content is fully loaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this actually have to do with loading? since we already checked that in !loadingChat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question it was to add a delay for dom rendering but I went ahead and refactored to use a callback from progressive message list instead and its much cleaner and more reliable 👍
|
.bundle |
macOS ARM64 Desktop App (Apple Silicon)📱 Download macOS Desktop App (arm64, unsigned) Instructions: |
…data * 'main' of github.com:block/goose: improve auto scroll to bottom + detection (#4504) Fix unable to get access to microphone in Mac app (#4571) Use middleware to verify secret key (#4338) adding Vercel MCP (#4562) docs: reorganizing CLI commands (#4566) Desktop import yaml recipes (#4544)
Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
Pull Request Description
During chat the window is not auto scrolling to the bottom after an agent response. This adds detection if the user is near the bottom of scroll and debouncing with timeouts to avoid jumpiness.
Also fixes the window not auto scrolling to the bottom when resuming sessions