Use middleware to verify secret key #4338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
force-pushed
the
jackamadeo/middleware
branch
from
922d993 to
ff3c703
Compare
DOsinga
approved these changes
Aug 26, 2025
crates/goose-server/src/auth.rs
Outdated
| response::Response, | ||
| }; | ||
|
|
||
| pub async fn layer_fn( |
Collaborator
There was a problem hiding this comment.
is this the normal way to name these? check_token would be easier to follow
Collaborator
Author
There was a problem hiding this comment.
Nope it's just a bad name
| @@ -1,12 +1,14 @@ | |||
| use std::sync::Arc; | |||
|
|
|||
| use crate::configuration; | |||
Collaborator
There was a problem hiding this comment.
we should really name this differently :) I was like, why is this in agent.rs
ui/desktop/src/goosed.ts
Outdated
| headers: { | ||
| 'X-Secret-Key': secret, | ||
| }, | ||
| }); |
Collaborator
There was a problem hiding this comment.
could we use the generated API at this point or would it not be ready (or is it only on the other side?)
Collaborator
Author
There was a problem hiding this comment.
looks like we don't actually add this endpoint to the generated client. It's also a bit of a mixed bag all over where we do vs don't use the generated client. I'll have a look at cleaning that up too, as this PR is kind of a logical place to do it
Collaborator
There was a problem hiding this comment.
yeah, it's all over the place. we should really set an alert on getSecret appearing in PRs
# Conflicts: # crates/goose-server/src/commands/agent.rs # crates/goose-server/src/routes/agent.rs # crates/goose-server/src/routes/audio.rs # crates/goose-server/src/routes/config_management.rs # crates/goose-server/src/routes/context.rs # crates/goose-server/src/routes/extension.rs # crates/goose-server/src/routes/reply.rs # crates/goose-server/src/routes/session.rs # crates/goose-server/src/state.rs # crates/goose-server/tests/pricing_api_test.rs
jamadeo
force-pushed
the
jackamadeo/middleware
branch
from
ff3c703 to
fda12f7
Compare
Merged
katzdave
added a commit
that referenced
this pull request
Sep 9, 2025
…data * 'main' of github.com:block/goose: improve auto scroll to bottom + detection (#4504) Fix unable to get access to microphone in Mac app (#4571) Use middleware to verify secret key (#4338) adding Vercel MCP (#4562) docs: reorganizing CLI commands (#4566) Desktop import yaml recipes (#4544)
thebristolsound
pushed a commit
to thebristolsound/goose
that referenced
this pull request
Sep 11, 2025
Signed-off-by: Matt Donovan <[email protected]>
tlongwell-block
added a commit
that referenced
this pull request
Sep 19, 2025
- Adapt to middleware-based authentication from PR #4338 - Remove verify_secret_key in favor of middleware auth - Update AppState initialization to match new signature - Preserve all Agent Manager functionality for per-session isolation - Keep graceful shutdown improvements for cleanup task - Fix test compilation issues with RawTextContent meta field This completes the Agent Manager POC addressing Discussion #4389: - Each session gets its own isolated agent - Extensions don't interfere between sessions - Cleanup task manages memory with graceful shutdown - Foundation laid for scheduler/recipe integration
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.