Skip to content

no streaming for ollama and re-arrange cards #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelneale merged 3 commits into from
Aug 26, 2025
Merged

no streaming for ollama and re-arrange cards #4335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
394dc71
no streaming for ollama and re-arrange cards
michaelneale Aug 25, 2025
aa1d88b
capitalize
michaelneale Aug 26, 2025
f87a2ba
re-trigger
michaelneale Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/goose/src/providers/ollama.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ impl OllamaProvider {
Ok(Self {
api_client,
model,
supports_streaming: true,
supports_streaming: false,
})
}

Expand Down
70 changes: 35 additions & 35 deletions ui/desktop/src/components/ProviderGuard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,39 @@ export default function ProviderGuard({ children }: ProviderGuardProps) {
</div>
</div>

{/* Other providers Card - outline style */}
<div
onClick={() => navigate('/welcome', { replace: true })}
className="w-full p-4 sm:p-6 bg-transparent border border-background-hover rounded-xl hover:border-text-muted transition-all duration-200 cursor-pointer group"
>
<div className="flex items-start justify-between mb-3">
<div className="flex-1">
<h3 className="font-medium text-text-standard text-sm sm:text-base">
Other providers
</h3>
</div>
<div className="text-text-muted group-hover:text-text-standard transition-colors">
<svg
className="w-4 h-4 sm:w-5 sm:h-5"
fill="none"
stroke="currentColor"
viewBox="0 0 24 24"
>
<path
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={2}
d="M9 5l7 7-7 7"
/>
</svg>
</div>
</div>
<p className="text-text-muted text-sm sm:text-base">
If you've already signed up for providers like Anthropic, OpenAI etc, you can
enter your own keys.
</p>
</div>

{/* Ollama Card - outline style */}
<div className="relative">
{/* Detected badge - similar to recommended but green */}
Expand Down Expand Up @@ -438,44 +471,11 @@ export default function ProviderGuard({ children }: ProviderGuardProps) {
</div>
</div>
<p className="text-text-muted text-sm sm:text-base">
Run AI models locally on your computer. Completely free and private with no
internet required.
Advanced: Run AI models locally on your computer. Completely free and private
with no internet required. (Does require significant hardware)
</p>
</div>
</div>

{/* Other providers Card - outline style */}
<div
onClick={() => navigate('/welcome', { replace: true })}
className="w-full p-4 sm:p-6 bg-transparent border border-background-hover rounded-xl hover:border-text-muted transition-all duration-200 cursor-pointer group"
>
<div className="flex items-start justify-between mb-3">
<div className="flex-1">
<h3 className="font-medium text-text-standard text-sm sm:text-base">
Other providers
</h3>
</div>
<div className="text-text-muted group-hover:text-text-standard transition-colors">
<svg
className="w-4 h-4 sm:w-5 sm:h-5"
fill="none"
stroke="currentColor"
viewBox="0 0 24 24"
>
<path
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={2}
d="M9 5l7 7-7 7"
/>
</svg>
</div>
</div>
<p className="text-text-muted text-sm sm:text-base">
If you've already signed up for providers like Anthropic, OpenAI etc, you can
enter your own keys.
</p>
</div>
</div>
</div>
</div>
Expand Down
Loading