Skip to content

fix: fixed chat mode extension list modal scroll #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanesq merged 1 commit into from
Aug 25, 2025
Merged

fix: fixed chat mode extension list modal scroll #4305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ui/desktop/src/components/settings/permission/PermissionRulesModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { useCallback, useEffect, useState } from 'react';
import { Dialog, DialogContent, DialogHeader, DialogTitle } from '../../ui/dialog';
import { ScrollArea } from '../../ui/scroll-area';
import { FixedExtensionEntry, useConfig } from '../../ConfigContext';
import { ChevronRight } from 'lucide-react';
import PermissionModal from './PermissionModal';
Expand Down Expand Up @@ -86,8 +85,8 @@ export default function PermissionRulesModal({ isOpen, onClose }: PermissionRule

return (
<Dialog open={isOpen} onOpenChange={onClose}>
<DialogContent className="sm:max-w-[800px] max-h-[80vh] p-0">
<DialogHeader className="px-8 pt-6 pb-4">
<DialogContent className="sm:max-w-[800px] max-h-[80vh] p-0 flex flex-col overflow-hidden">
<DialogHeader className="px-8 pt-6 pb-4 flex-shrink-0">
<div className="flex items-center gap-4">
<div className="rounded-full bg-background-inverse w-16 h-16 flex items-center justify-center">
<svg
Expand Down Expand Up @@ -117,25 +116,25 @@ export default function PermissionRulesModal({ isOpen, onClose }: PermissionRule
</div>
</DialogHeader>

<ScrollArea className="flex-1 px-8 pb-8">
<div className="space-y-8">
<div className="flex-1 overflow-y-auto px-8 pb-8 min-h-0">
<div className="space-y-4">
{/* Extension Rules Section */}
<RulesSection
title="Extension rules"
rules={
<>
<div className="space-y-2">
{extensions.map((extension) => (
<RuleItem
key={extension.name}
title={extension.name}
description={'description' in extension ? extension.description || '' : ''}
/>
))}
</>
</div>
}
/>
</div>
</ScrollArea>
</div>
</DialogContent>
</Dialog>
);
Expand Down
Loading