fix: fixed chat mode extension list modal scroll #4305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Collaborator
|
Yes, very good. Thank you! |
shellz-n-stuff
pushed a commit
to shellz-n-stuff/goose
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com> Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
This was referenced Aug 27, 2025
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com> Signed-off-by: Dorien Koelemeijer <dkoelemeijer@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #4275
Description:
Problem: The modal was cutting off content, and the scroll wasn't working properly.
Root Cause: The custom ScrollArea component wasn't working well with the Radix UI Dialog component's overflow handling.
Changes made:
Replaced custom ScrollArea with native browser scrolling using
overflow-y-autoPreview: (ignore differ styling as it is on Windows local env)