Make goosehints jinja templated #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman1993
commented
Sep 4, 2024
salman1993
commented
Sep 4, 2024
| system_prompt = Message.load("prompts/developer.jinja").text | ||
| if hints_path.is_file(): | ||
| goosehints = hints_path.read_text() | ||
| goosehints = render_template(hints_path) |
There was a problem hiding this comment.
i found the .goose.jinja file in this repo but couldn't find a reference on where/how it was being used
https://github.com/squareup/goose/blob/cffd4bfe8eaac603ec84c4c3b9e7f204cc91a948/.goose.jinja#L1
lukealvoeiro
approved these changes
Sep 4, 2024
| if not template_path.exists(): | ||
| raise FileNotFoundError(f"Template file {template_path} does not exist.") | ||
|
|
||
| env = Environment(loader=FileSystemLoader(template_path.parent)) |
There was a problem hiding this comment.
[nit] could we look up parent paths recursively up until we reach the repo root? this is because in a monorepo setting it might be included at a subproject level, or at the top level of the repo - and goose could be ran at either level.
There was a problem hiding this comment.
i am gonna hold off on this till for now & keep it simple so that it just uses the working directory hints.
|
fixed the formatting by running |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
@salman1993 a bit late to mention - but this is genius BTW ! love it |
lukealvoeiro
pushed a commit
that referenced
this pull request
Sep 9, 2024
lukealvoeiro
added a commit
that referenced
this pull request
Sep 9, 2024
* main: fix: typo in exchange method `rewind` (#54) fix: remove unsafe pop of messages (#47) chore: Update LICENSE (#53) chore(docs): update is_dangerous_command method description (#48) refactor: improve safety rails speed and prompt (#45) feat: make goosehints jinja templated (#43) ci: enforce PR title follows conventional commit (#14) feat: show available toolkits (#37) adding in ability to provide per repo hints (#32) Apply ruff and add to CI (#40) added some regex based checks for dangerous commands (#38) chore: Update publish github workflow to check package versions before publishing (#19) chore: upgrade ai-exchange dependency (#36) fix: resuming sessions (#35) feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34) fix: export metadata.plugins export should have valid module (#30) fix (#24) link to vs code extension (#20) Enable cli options for plugin (#22) Modified the readme to be more friendly to new users (#16)
Kvadratni
added a commit
to Kvadratni/goose
that referenced
this pull request
Sep 23, 2024
* origin/main: chore: release 0.9.0 (block#58) fix: goose should track files it reads and not overwrite changes (block#46) docs: Small dev notes for using exchange from source (block#50) fix: typo in exchange method `rewind` (block#54) fix: remove unsafe pop of messages (block#47) chore: Update LICENSE (block#53) chore(docs): update is_dangerous_command method description (block#48) refactor: improve safety rails speed and prompt (block#45) feat: make goosehints jinja templated (block#43) ci: enforce PR title follows conventional commit (block#14) feat: show available toolkits (block#37) adding in ability to provide per repo hints (block#32) Apply ruff and add to CI (block#40) added some regex based checks for dangerous commands (block#38) chore: Update publish github workflow to check package versions before publishing (block#19) # Conflicts: # src/goose/toolkit/developer.py # src/goose/utils/check_shell_command.py # tests/utils/test_check_shell_command.py
lily-de
pushed a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to
includefiles like README.md & CONTRIBUTING.md