Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goose version command fix #24

Merged
merged 1 commit into from
Aug 29, 2024
Merged

goose version command fix #24

merged 1 commit into from
Aug 29, 2024

Conversation

elenazherdeva
Copy link
Collaborator

@elenazherdeva elenazherdeva commented Aug 28, 2024

Solving the issue #29

  • Created an entry point for goose (goose-ai package)
  • Fixed the issue where modules weren’t imported correctly during the uv run goose version

Corresponding PR in exchange:
square/exchange#16

pyproject.toml Outdated
@@ -30,6 +30,9 @@ default = "goose.profile:default_profile"
[project.entry-points."goose.command"]
file = "goose.command.file:FileCommand"

[project.entry-points."metadata.plugins"]
goose-ai = ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take it doing something like package_name="goose-ai" didn't work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized the exports probably would overwrite each other for that case

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think you’re right! Good point

@zakiali
Copy link
Collaborator

zakiali commented Aug 29, 2024

Mind adding a description of this into the pr description?

Copy link
Contributor

@lukealvoeiro lukealvoeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending writing a PR description for posterity & and including the new version of exchange (that exports the correct group)

@elenazherdeva elenazherdeva force-pushed the ez/ai_exchange_new branch 2 times, most recently from 0230275 to 573ef95 Compare August 29, 2024 18:11
Copy link
Collaborator

@zakiali zakiali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@elenazherdeva elenazherdeva merged commit dd510a7 into main Aug 29, 2024
1 check passed
lukealvoeiro added a commit that referenced this pull request Sep 4, 2024
…l-commit-title-pr

* origin/main:
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
  chore: gitignore generated lockfile (#15)
  add prompts (#11)
  conditionally publish only when config changes (#9)
lukealvoeiro pushed a commit that referenced this pull request Sep 9, 2024
lukealvoeiro added a commit that referenced this pull request Sep 9, 2024
* main:
  fix: typo in exchange method `rewind` (#54)
  fix: remove unsafe pop of messages (#47)
  chore: Update LICENSE (#53)
  chore(docs): update is_dangerous_command method description (#48)
  refactor: improve safety rails speed and prompt (#45)
  feat: make goosehints jinja templated (#43)
  ci: enforce PR title follows conventional commit (#14)
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
lily-de pushed a commit that referenced this pull request Oct 7, 2024
@lamchau lamchau deleted the ez/ai_exchange_new branch October 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants