-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore: remove the google drive built-in extension #4187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jamadeo
commented
Aug 19, 2025
- deletes the extension itself
- updates the bundled extension syncing to also check for deprecated built-ins
| for (let i = existingExtensions.length - 1; i >= 0; i--) { | ||
| const ext = existingExtensions[i]; | ||
| if (ext.type == 'builtin' && DEPRECATED_BUILTINS.includes(ext.name)) { | ||
| existingExtensions.splice(i, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would modify the in memory copy of the existing extensions read from the config, but wouldn't remove the extension from the config file
I assume we want something that does that, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's still in my config file. I thought this would sync them back to the config but I guess it doesn't? I don't see it in the extensions UI and if I ask Goose to use drive it does not find it. But I suppose if I ran the CLI it would pick it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this doesn't do it perfectly but I think it has the intended effect. It will refuse to load the deprecated extension and then if it sees a 'googledrive' bundled extension, it will be replaced. If not, it will just ignore it. It's not a perfect clean-up of the config but any other solution would mean adding a "migration" hook/step in the config load/save, which would be nice to avoid if possible. This way at least it all lives in the same place.
…-visual-improvements * 'main' of github.com:block/goose: (21 commits) Custom providers update (#4099) docs: goose_terminal env var (#4205) Desktop alerts when suspicious unicode characters found in Recipe (#4080) chore: remove the google drive built-in extension (#4187) Move out app init (#4185) Remove unused extension stuff (#4166) Added tests for extensions functionality (#3794) chore(release): release version 1.5.0 (#4169) Fix tests from upstream changes and add testing to lint staged and ci (#4127) Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) ...
Signed-off-by: Jack Wright <[email protected]>
* main: docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799) Don't show a confirm dialog for quitting (#4225) Fix: Missing smart_approve in CLI /mode help text and error message (#4132) Clean up langfuse docs and scripts (#4220) feat: add remark-breaks plugin to preserve single newlines in markdown (#4217) feat(mcp/developer): accept -1 for insert_line number (#4112) Remove dead code and old settings migration (#4180) removed tests from lint-staged (#4203) docs: openrouter and ollama easy desktop setup (#4195) Custom providers update (#4099) docs: goose_terminal env var (#4205) Desktop alerts when suspicious unicode characters found in Recipe (#4080) chore: remove the google drive built-in extension (#4187) Move out app init (#4185)