Fix tests from upstream changes and add testing to lint staged and ci #4127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add npm run test to ci Add npm dependency caching Node.js in CI workflows
zanesq
commented
Aug 16, 2025
| run: | | ||
| source ./bin/activate-hermit | ||
| cd ui/desktop | ||
| npm cache clean --force || true |
Collaborator
Author
There was a problem hiding this comment.
@michaelneale do we need this npm cache clean with linux?
jamadeo
approved these changes
Aug 18, 2025
| # Clean Homebrew cache | ||
| brew cleanup || true | ||
| # Remove unnecessary large directories | ||
| rm -rf ~/Library/Caches/* || true |
Collaborator
There was a problem hiding this comment.
you can remove this whole step now, all that's left is activate hermit but that would only be until the end of the step execution, so effectively all it's doing is dh -h
| sudo rm -rf /usr/local/share/boost || true | ||
| # Clean apt cache | ||
| sudo apt-get clean || true | ||
| sudo apt-get autoremove -y || true |
Collaborator
There was a problem hiding this comment.
same here, just remove the whole step
| # Clean Homebrew cache | ||
| brew cleanup || true | ||
| # Remove unnecessary large directories | ||
| rm -rf ~/Library/Caches/* || true |
…npm-cacheing * 'main' of github.com:block/goose: Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130)
zanesq
added a commit
that referenced
this pull request
Aug 19, 2025
* 'main' of github.com:block/goose: (51 commits) Fix tests from upstream changes and add testing to lint staged and ci (#4127) Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) Docs: Auto-compact context (#4116) chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 in /documentation (#4149) Recipe config to limit tool availability (#4020) docs: fix warning message (#4148) feat: adds cursor-agent as a cli provider (#4101) chore: remove vector search tool selection strategy (#3933) docs: add streamable_http install links (#4130) feat: iterating on summarize oneshot prompt (#4113) ... # Conflicts: # ui/desktop/src/App.test.tsx
zanesq
added a commit
that referenced
this pull request
Aug 19, 2025
* 'main' of github.com:block/goose: Remove unused extension stuff (#4166) Added tests for extensions functionality (#3794) chore(release): release version 1.5.0 (#4169) Fix tests from upstream changes and add testing to lint staged and ci (#4127) Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798)
zanesq
added a commit
that referenced
this pull request
Aug 19, 2025
…-visual-improvements * 'main' of github.com:block/goose: (21 commits) Custom providers update (#4099) docs: goose_terminal env var (#4205) Desktop alerts when suspicious unicode characters found in Recipe (#4080) chore: remove the google drive built-in extension (#4187) Move out app init (#4185) Remove unused extension stuff (#4166) Added tests for extensions functionality (#3794) chore(release): release version 1.5.0 (#4169) Fix tests from upstream changes and add testing to lint staged and ci (#4127) Unlist figma tutorial (#4186) feat(ui): Implement in-place message editing with re-response (#3798) Retry all 500 codes (#4160) blog: Transforming AI Assistance with Goose Mentor Mode (#4151) upgraded all npm packages and fixed related issues (#4072) Docs: @-mentions in goosehints (#4171) fix: consistent font sizing in ToolCallWithResponse (#4167) Temporarily disable TODO Tool (#4158) docs: add integrated MCP server config to jetbrains tutorial (#4120) docs: remove figma MCP from suggested servers (#4123) Blog: The AI Skeptic’s Guide to Context Windows (#4152) ...
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
…block#4127) Signed-off-by: Jack Wright <jack.wright@nike.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests from upstream changes and add testing to lint staged and ci
Also added npm dependency caching Node.js to speed up CI workflows