Adding better deeplink support for streamable-http #3986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackgirlbytes
requested review from
EbonyLouis,
angiejones,
dianed-square,
jamadeo and
michaelneale
angiejones
reviewed
Aug 9, 2025
angiejones
approved these changes
Aug 9, 2025
Co-authored-by: Angie Jones <[email protected]>
michaelneale
added a commit
that referenced
this pull request
Aug 11, 2025
* main: add missing dependencies for developer setup (#3930) blog: subagents workshop (#3993) Adding better deeplink support for streamable-http (#3986) Docs: Add Kiwi Flight Search Extension Tutorial (#3985) Revert "Fix file extension on signed osx release (#3974)" Fix file extension on signed osx release (#3974) Dagger container-use MCP (#3932) Add Sunno Song Generator To Recipe Cookbook (#3969) docs: update jetbrains tutorial (#3971) chore: update linux build - don't run on every PR (#3961)
katzdave
added a commit
that referenced
this pull request
Aug 12, 2025
* 'main' of github.com:block/goose: docs: update release docs with an additional step needed + adjust list formatting (#4005) chore(release): release version 1.3.0 (#3921) docs: MCP-ui blog content (#3996) feat: Add `GOOSE_TERMINAL` env variable to spawned terminals (#3911) add missing dependencies for developer setup (#3930) blog: subagents workshop (#3993) Adding better deeplink support for streamable-http (#3986) Docs: Add Kiwi Flight Search Extension Tutorial (#3985) Revert "Fix file extension on signed osx release (#3974)" Fix file extension on signed osx release (#3974) Dagger container-use MCP (#3932) Add Sunno Song Generator To Recipe Cookbook (#3969) docs: update jetbrains tutorial (#3971) chore: update linux build - don't run on every PR (#3961)
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
Co-authored-by: Angie Jones <[email protected]> Signed-off-by: Jack Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Deeplinks for streamable HTTP extensions had two issues:
transport=streamable_http, ignoredtype=streamable_http(some organizations like Kiwi Flight search have the goose URIThis caused extensions like Kiwi.com to be registered as SSE instead of streamable_http, and prevented extensions requiring auth headers from working via deeplinks.
Solution
Enhanced the deeplink parser to:
transportandtypeparametersheader=key%3Dvalueparameters for streamable HTTP extensionsWhy
typeParameter Support?The deeplink parser only recognized
transport=streamable_httpbut the actual config schema usestype: 'streamable_http'. This inconsistency led extension developers (like Kiwi.com) to naturally usetype=streamable_httpin their deeplinks, expecting it to match the config field name.The fix maintains backward compatibility with
transportwhile adding support for the more intuitivetypeparameter that aligns with the config schema.Examples Now Working
Fixes #3438