feat: Add GOOSE_TERMINAL env variable to spawned terminals
#3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iamrajiv <[email protected]>
Collaborator
|
I think this is ok, good use of env! |
simonsickle
approved these changes
Aug 8, 2025
Contributor
simonsickle
left a comment
simonsickle
left a comment
There was a problem hiding this comment.
Nice! This should allow for customization of the bash / zsh profile to restrict tooling like the find command for example.
michaelneale
approved these changes
Aug 11, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
LGTM - seems sensible
lifeizhou-ap
added a commit
that referenced
this pull request
Aug 12, 2025
* main: feat: add @-mention file reference expansion to .goosehints (#3873) feat(cli): Add --name/-n to session remove and --id/-i alias for session export (#3941) Docs: provider and model run options (#4013) To-Do Tools (#3902) ci: correctly match doc only changes (#4009) Remove PR trigger for Linux build workflow (#4008) docs: update release docs with an additional step needed + adjust list formatting (#4005) chore(release): release version 1.3.0 (#3921) docs: MCP-ui blog content (#3996) feat: Add `GOOSE_TERMINAL` env variable to spawned terminals (#3911) add missing dependencies for developer setup (#3930)
katzdave
added a commit
that referenced
this pull request
Aug 12, 2025
* 'main' of github.com:block/goose: docs: update release docs with an additional step needed + adjust list formatting (#4005) chore(release): release version 1.3.0 (#3921) docs: MCP-ui blog content (#3996) feat: Add `GOOSE_TERMINAL` env variable to spawned terminals (#3911) add missing dependencies for developer setup (#3930) blog: subagents workshop (#3993) Adding better deeplink support for streamable-http (#3986) Docs: Add Kiwi Flight Search Extension Tutorial (#3985) Revert "Fix file extension on signed osx release (#3974)" Fix file extension on signed osx release (#3974) Dagger container-use MCP (#3932) Add Sunno Song Generator To Recipe Cookbook (#3969) docs: update jetbrains tutorial (#3971) chore: update linux build - don't run on every PR (#3961)
5 tasks
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
) Signed-off-by: iamrajiv <[email protected]> Signed-off-by: Jack Wright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3827