Skip to content

fix param order of debug_conversation_fixer #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamadeo merged 2 commits into from
Aug 4, 2025
Merged

fix param order of debug_conversation_fixer #3796

jamadeo merged 2 commits into from
Aug 4, 2025

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Aug 1, 2025 

pub fn debug_conversation_fix(
    messages: &[Message],
    fixed: &[Message],
    issues: &[String],
) -> String {

@jamadeo jamadeo requested a review from DOsinga August 1, 2025 21:22
@jamadeo jamadeo merged commit f7de359 into main Aug 4, 2025
9 checks passed
@jamadeo jamadeo deleted the jackamadeo/fix-the-fixer-debug branch August 4, 2025 16:13
katzdave added a commit that referenced this pull request Aug 4, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/token-counti…
f7386c1 
…ng-quickfix

* 'main' of github.com:block/goose: (26 commits)
  docs: Add YouTube link to Git MCP Tutorial (#3831)
  feat: more robust client initialization for the app (#3830)
  Build app bundles on release branches always (#3789)
  fix param order of debug_conversation_fixer (#3796)
  Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791)
  File completion in CLI (#3822)
  docs: Dynamic linux install buttons (#3810)
  tests: Add missing `#[serial]` to two tests (#3816)
  Chore: apply more clippy rules to prevent from code complexity (#3813)
  chore(mcp): Add helpers to parse parameters (#2821)
  feat: enable docusaurus respectPrefersColorScheme (#3746)
  fix session resume in new window (#3800)
  Add settings field documentation to recipe guides (#3809)
  chore(deps): bump on-headers and compression in /documentation (#3532)
  fix(ui): refresh provider related issues (#3385)
  feat: Add comprehensive Linux build support (#3673)
  developer: Optimize text_editor_view a bit (#3781)
  Override session name generator for ollama provider (#3710)
  docs: fix markdown for cognee tutorial (#3801)
  chore: Upgrade node (#3756)
  ...
michaelneale added a commit that referenced this pull request Aug 4, 2025
@michaelneale
Merge branch 'main' into micn/large-file-read
d78b407 
* main: (34 commits)
  Token counting in Auto-compact uses provider metadata (#3788)
  docs: Add YouTube link to Git MCP Tutorial (#3831)
  feat: more robust client initialization for the app (#3830)
  Build app bundles on release branches always (#3789)
  fix param order of debug_conversation_fixer (#3796)
  Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791)
  File completion in CLI (#3822)
  docs: Dynamic linux install buttons (#3810)
  tests: Add missing `#[serial]` to two tests (#3816)
  Chore: apply more clippy rules to prevent from code complexity (#3813)
  chore(mcp): Add helpers to parse parameters (#2821)
  feat: enable docusaurus respectPrefersColorScheme (#3746)
  fix session resume in new window (#3800)
  Add settings field documentation to recipe guides (#3809)
  chore(deps): bump on-headers and compression in /documentation (#3532)
  fix(ui): refresh provider related issues (#3385)
  feat: Add comprehensive Linux build support (#3673)
  developer: Optimize text_editor_view a bit (#3781)
  Override session name generator for ollama provider (#3710)
  docs: fix markdown for cognee tutorial (#3801)
  ...
michaelneale added a commit that referenced this pull request Aug 5, 2025
@michaelneale
Merge branch 'main' into generic-retry-and-error-parsing
6582658 
* main:
  Token counting in Auto-compact uses provider metadata (#3788)
  docs: Add YouTube link to Git MCP Tutorial (#3831)
  feat: more robust client initialization for the app (#3830)
  Build app bundles on release branches always (#3789)
  fix param order of debug_conversation_fixer (#3796)
  Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791)
  File completion in CLI (#3822)
michaelneale added a commit that referenced this pull request Aug 5, 2025
@michaelneale
Merge branch 'main' into micn/morph-new-model
25cb033 
* main: (56 commits)
  Token counting in Auto-compact uses provider metadata (#3788)
  docs: Add YouTube link to Git MCP Tutorial (#3831)
  feat: more robust client initialization for the app (#3830)
  Build app bundles on release branches always (#3789)
  fix param order of debug_conversation_fixer (#3796)
  Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791)
  File completion in CLI (#3822)
  docs: Dynamic linux install buttons (#3810)
  tests: Add missing `#[serial]` to two tests (#3816)
  Chore: apply more clippy rules to prevent from code complexity (#3813)
  chore(mcp): Add helpers to parse parameters (#2821)
  feat: enable docusaurus respectPrefersColorScheme (#3746)
  fix session resume in new window (#3800)
  Add settings field documentation to recipe guides (#3809)
  chore(deps): bump on-headers and compression in /documentation (#3532)
  fix(ui): refresh provider related issues (#3385)
  feat: Add comprehensive Linux build support (#3673)
  developer: Optimize text_editor_view a bit (#3781)
  Override session name generator for ollama provider (#3710)
  docs: fix markdown for cognee tutorial (#3801)
  ...
kathawthorne added a commit to kathawthorne/goose that referenced this pull request Aug 5, 2025
@kathawthorne
Merge remote-tracking branch 'upstream/main' into kh/support-agent-md…
0e56165 
…-files

* upstream/main: (150 commits)
  fix: replace glob/grep tool with shell (block#3834)
  docs: Add Youtube Link to dev.to tutorial (block#3869)
  Changed app settings configuration form to match settings panels (block#3829)
  Tell the user to hit compact (block#3851)
  Pin @mcp-ui/client in package.json (block#3860)
  blog for mcp-jupyter server (block#3059)
  docs: Adding dev.to Tutorial & Update CLI Component (block#3828)
  Detect client disconnects and cancel tool calls (block#3782)
  Suppress ansi with pipes (block#3775)
  Fix leaky env variable causing flaky test (block#3761)
  Update gemini error msg (block#3847)
  Generic retry and error parsing (block#3558)
  Clear the current line on ctrl-c in line with other tools (block#3764)
  chore: upgrade morph to use new model with instruction (block#3745)
  add CODEOWNERS file with /documentation owners (block#3840)
  Token counting in Auto-compact uses provider metadata (block#3788)
  docs: Add YouTube link to Git MCP Tutorial (block#3831)
  feat: more robust client initialization for the app (block#3830)
  Build app bundles on release branches always (block#3789)
  fix param order of debug_conversation_fixer (block#3796)
  ...

# Conflicts:
#	crates/goose-mcp/src/developer/mod.rs
@alexhancock alexhancock mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamadeo @DOsinga