Override session name generator for ollama provider #3710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelahning
force-pushed
the
aning/ollama
branch
5 times, most recently
from
add8637 to
ffa5964
Compare
angelahning
force-pushed
the
aning/ollama
branch
from
ffa5964 to
c00026d
Compare
DOsinga
approved these changes
Jul 29, 2025
crates/goose/src/providers/ollama.rs
Outdated
| description = Self::filter_reasoning_tokens(&description); | ||
|
|
||
| let sanitized_description = if description.chars().count() > 100 { | ||
| safe_truncate(&description, 100) |
Collaborator
There was a problem hiding this comment.
safe_truncate already does check for length, so need to do that here. good to use chars().count) though
Collaborator
Author
There was a problem hiding this comment.
ahh looks like we do that in the original code too. Let me clean both up
crates/goose/src/providers/base.rs
Outdated
| .filter(|m| m.role == rmcp::model::Role::User) | ||
| .take(3) | ||
| .map(|m| m.as_concat_text()) | ||
| .collect(); |
Collaborator
There was a problem hiding this comment.
should we pass this in, instead of messages? the outer callers are only going to call us with the first three messages anyway (which I guess also means we should probably not cut at 3 here at all)
crates/goose/src/providers/ollama.rs
Outdated
| let message = Message::user().with_text(&self.create_session_name_prompt(messages)); | ||
| let result = self | ||
| .complete( | ||
| "You are a title generator. Output only the requested title with no additional text, reasoning, or explanations.", |
Collaborator
There was a problem hiding this comment.
shouldn't we tell it to keep it to 4 words here too?
Collaborator
Author
There was a problem hiding this comment.
we tell it in the prompt already. I can also add it here.
angelahning
force-pushed
the
aning/ollama
branch
from
44d308c to
eeeef73
Compare
angelahning
force-pushed
the
aning/ollama
branch
from
eeeef73 to
07e79cd
Compare
katzdave
added a commit
that referenced
this pull request
Aug 4, 2025
…ng-quickfix * 'main' of github.com:block/goose: (26 commits) docs: Add YouTube link to Git MCP Tutorial (#3831) feat: more robust client initialization for the app (#3830) Build app bundles on release branches always (#3789) fix param order of debug_conversation_fixer (#3796) Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791) File completion in CLI (#3822) docs: Dynamic linux install buttons (#3810) tests: Add missing `#[serial]` to two tests (#3816) Chore: apply more clippy rules to prevent from code complexity (#3813) chore(mcp): Add helpers to parse parameters (#2821) feat: enable docusaurus respectPrefersColorScheme (#3746) fix session resume in new window (#3800) Add settings field documentation to recipe guides (#3809) chore(deps): bump on-headers and compression in /documentation (#3532) fix(ui): refresh provider related issues (#3385) feat: Add comprehensive Linux build support (#3673) developer: Optimize text_editor_view a bit (#3781) Override session name generator for ollama provider (#3710) docs: fix markdown for cognee tutorial (#3801) chore: Upgrade node (#3756) ...
michaelneale
added a commit
that referenced
this pull request
Aug 4, 2025
* main: (34 commits) Token counting in Auto-compact uses provider metadata (#3788) docs: Add YouTube link to Git MCP Tutorial (#3831) feat: more robust client initialization for the app (#3830) Build app bundles on release branches always (#3789) fix param order of debug_conversation_fixer (#3796) Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791) File completion in CLI (#3822) docs: Dynamic linux install buttons (#3810) tests: Add missing `#[serial]` to two tests (#3816) Chore: apply more clippy rules to prevent from code complexity (#3813) chore(mcp): Add helpers to parse parameters (#2821) feat: enable docusaurus respectPrefersColorScheme (#3746) fix session resume in new window (#3800) Add settings field documentation to recipe guides (#3809) chore(deps): bump on-headers and compression in /documentation (#3532) fix(ui): refresh provider related issues (#3385) feat: Add comprehensive Linux build support (#3673) developer: Optimize text_editor_view a bit (#3781) Override session name generator for ollama provider (#3710) docs: fix markdown for cognee tutorial (#3801) ...
michaelneale
added a commit
that referenced
this pull request
Aug 5, 2025
* main: (56 commits) Token counting in Auto-compact uses provider metadata (#3788) docs: Add YouTube link to Git MCP Tutorial (#3831) feat: more robust client initialization for the app (#3830) Build app bundles on release branches always (#3789) fix param order of debug_conversation_fixer (#3796) Fix directory switcher not working in active chat sessions and file browser not defaulting to current session directory path (#3791) File completion in CLI (#3822) docs: Dynamic linux install buttons (#3810) tests: Add missing `#[serial]` to two tests (#3816) Chore: apply more clippy rules to prevent from code complexity (#3813) chore(mcp): Add helpers to parse parameters (#2821) feat: enable docusaurus respectPrefersColorScheme (#3746) fix session resume in new window (#3800) Add settings field documentation to recipe guides (#3809) chore(deps): bump on-headers and compression in /documentation (#3532) fix(ui): refresh provider related issues (#3385) feat: Add comprehensive Linux build support (#3673) developer: Optimize text_editor_view a bit (#3781) Override session name generator for ollama provider (#3710) docs: fix markdown for cognee tutorial (#3801) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3294