-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: list Databricks-supported models and enable fuzzy search during model configuration #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kvadratni
merged 2 commits into
block:main
from
wpfleger96:wpfleger/support-list-provider-models
Jun 23, 2025
Merged
feat: list Databricks-supported models and enable fuzzy search during model configuration #3039
Kvadratni
merged 2 commits into
block:main
from
wpfleger96:wpfleger/support-list-provider-models
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
approved these changes
Jun 23, 2025
Collaborator
jamadeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good find on the fuzzy search option!
| .map(|m| (m, m.as_str(), "")) | ||
| .collect::<Vec<_>>(), | ||
| ) | ||
| .filter_mode() // enable "fuzzy search" filtering for the list of models |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
jessejacksonafterpay
added a commit
to jessejacksonafterpay/goose
that referenced
this pull request
Jun 24, 2025
…text-addition * upstream/main: fix temporal build for windows (block#3045) fix cron parsing for windows (block#3044) feat: list Databricks-supported models and enable fuzzy search during model configuration (block#3039) fix: update index when tool selection strategy changes (block#2991) docs: Add "Add Recipe button" To Recipe Cookbook (block#3038) fix: issue when parsing recipe parameters (block#3031) fix: Improves reliability of flaky log tests (block#3029)
michaelneale
added a commit
that referenced
this pull request
Jun 24, 2025
* main: fix temporal build for windows (#3045) fix cron parsing for windows (#3044) feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039) fix: update index when tool selection strategy changes (#2991) docs: Add "Add Recipe button" To Recipe Cookbook (#3038) fix: issue when parsing recipe parameters (#3031)
btdeviant
pushed a commit
to btdeviant/goose
that referenced
this pull request
Jun 25, 2025
… model configuration (block#3039)
laanak08
added a commit
that referenced
this pull request
Jun 26, 2025
# By Alice Hau (6) and others # Via Alice Hau * ahau/tool-strategy: (27 commits) fix merge merged updated computercontroller and developer descriptions add additional strats to test fmt update to get vector db path from env var feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039) fix: update index when tool selection strategy changes (#2991) docs: Add "Add Recipe button" To Recipe Cookbook (#3038) fix: issue when parsing recipe parameters (#3031) fix: Improves reliability of flaky log tests (#3029) Add xAI Test Coverage (#3020) Reorganizing tutorials (#3028) feat(providers): update Google Gemini models to latest available models (#2989) fix(docker): install protoc to fix lance-encoding build (#2995) fix: updated openrouter known models (#3021) Mnovich/temporal foreground tasks (#2895) add 'install in goose' asset (#3016) Added useDarkMode hook for detecting dark mode setting dynamically (#3019) docs: add sagemaker provider (#2980) ... # Conflicts: # .gitignore # crates/goose/src/agents/router_tools.rs
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
… model configuration (block#3039) Signed-off-by: Soroosh <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
… model configuration (block#3039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
fetch_supported_models_asyncfunction for the Databricks provider. this allows users to interactively select their model during configuration, instead of needing to know the model name ahead of time and typing it in manually. This aligns with how most of the other provider interfaces are implemented (e.g. openai.rs, anthropic.rs). In case of error we returnNoneso the prompt can still fall back to manual inputcliclackprompt. this allows users to type a fuzzy match query against the list of provider models that will dynamically filter the results, making it easier to find the model they're looking for since the lists of supported models can be quite long (e.g. OpenAI provider has 587 supported models, Databricks has 104 supported models)Before this change, Databricks provider model names must be manually input:
After this change, Databricks provider model can be chosen interactively:
And can also be fuzzy searched (e.g.
databricks-):