Skip to content

Conversation

@wpfleger96
Copy link
Collaborator

@wpfleger96 wpfleger96 commented Jun 23, 2025

This PR adds the following changes:

  • implement the fetch_supported_models_async function for the Databricks provider. this allows users to interactively select their model during configuration, instead of needing to know the model name ahead of time and typing it in manually. This aligns with how most of the other provider interfaces are implemented (e.g. openai.rs, anthropic.rs). In case of error we return None so the prompt can still fall back to manual input
  • enable "fuzzy search" filtering on the cliclack prompt. this allows users to type a fuzzy match query against the list of provider models that will dynamically filter the results, making it easier to find the model they're looking for since the lists of supported models can be quite long (e.g. OpenAI provider has 587 supported models, Databricks has 104 supported models)

Before this change, Databricks provider model names must be manually input:

┌   goose-configure
│
◇  What would you like to configure?
│  Configure Providers
│
◇  Which model provider should we use?
│  Databricks
│
●  DATABRICKS_HOST is already configured
│
◇  Would you like to update this value?
│  No
│
◇  Model fetch complete
│
◆  Enter a model from that provider:
│  databricks-claude-3-7-sonnet (default)

After this change, Databricks provider model can be chosen interactively:

   goose-configure
│
◇  What would you like to configure?
│  Configure Providers
│
◇  Which model provider should we use?
│  Databricks
│
●  DATABRICKS_HOST is already configured
│
◇  Would you like to update this value?
│  No
│
◇  Model fetch complete
│
◆  Select a model:
│
│  ● baxen-migration-demo
│  ○ big-hack
│  ○ case_history_hackweek
│  ○ case-history-checker
│  ○ claude-3-5-haiku
│  ○ claude-3-5-sonnet
│  ○ claude-3-5-sonnet-2
│  ○ claude-3-7-sonnet
.......

And can also be fuzzy searched (e.g. databricks-):

┌   goose-configure
│
◇  What would you like to configure?
│  Configure Providers
│
◇  Which model provider should we use?
│  Databricks
│
●  DATABRICKS_HOST is already configured
│
◇  Would you like to update this value?
│  No
│
◇  Model fetch complete
│
◆  Select a model:
│  databricks-
│  ● databricks-gte-large-en
│  ○ databricks-bge-large-en
│  ○ databricks-claude-sonnet-4
│  ○ databricks-llama-4-maverick
│  ○ databricks-claude-3-7-sonnet

@wpfleger96 wpfleger96 changed the title feat: list Databricks-supported models and enable fuzzy search during CLI configuration feat: list Databricks-supported models and enable fuzzy search during model configuration Jun 23, 2025
Copy link
Collaborator

@jamadeo jamadeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good find on the fuzzy search option!

.map(|m| (m, m.as_str(), ""))
.collect::<Vec<_>>(),
)
.filter_mode() // enable "fuzzy search" filtering for the list of models
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Kvadratni Kvadratni merged commit a4546d4 into block:main Jun 23, 2025
6 checks passed
jessejacksonafterpay added a commit to jessejacksonafterpay/goose that referenced this pull request Jun 24, 2025
…text-addition

* upstream/main:
  fix temporal build for windows (block#3045)
  fix cron parsing for windows (block#3044)
  feat: list Databricks-supported models and enable fuzzy search during model configuration (block#3039)
  fix: update index when tool selection strategy changes (block#2991)
  docs: Add "Add Recipe button" To Recipe Cookbook (block#3038)
  fix: issue when parsing recipe parameters (block#3031)
  fix: Improves reliability of flaky log tests (block#3029)
michaelneale added a commit that referenced this pull request Jun 24, 2025
* main:
  fix temporal build for windows (#3045)
  fix cron parsing for windows (#3044)
  feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039)
  fix: update index when tool selection strategy changes (#2991)
  docs: Add "Add Recipe button" To Recipe Cookbook (#3038)
  fix: issue when parsing recipe parameters (#3031)
btdeviant pushed a commit to btdeviant/goose that referenced this pull request Jun 25, 2025
laanak08 added a commit that referenced this pull request Jun 26, 2025
# By Alice Hau (6) and others
# Via Alice Hau
* ahau/tool-strategy: (27 commits)
  fix merge
  merged
  updated computercontroller and developer descriptions
  add additional strats to test
  fmt
  update to get vector db path from env var
  feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039)
  fix: update index when tool selection strategy changes (#2991)
  docs: Add "Add Recipe button" To Recipe Cookbook (#3038)
  fix: issue when parsing recipe parameters (#3031)
  fix: Improves reliability of flaky log tests (#3029)
  Add xAI Test Coverage (#3020)
  Reorganizing tutorials (#3028)
  feat(providers): update Google Gemini models to latest available models (#2989)
  fix(docker): install protoc to fix lance-encoding build (#2995)
  fix: updated openrouter known models (#3021)
  Mnovich/temporal foreground tasks (#2895)
  add 'install in goose' asset (#3016)
  Added useDarkMode hook for detecting dark mode setting dynamically (#3019)
  docs: add sagemaker provider (#2980)
  ...

# Conflicts:
#	.gitignore
#	crates/goose/src/agents/router_tools.rs
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants