fix: issue when parsing recipe parameters #3031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeizhou-ap
changed the title
lifeizhou-ap
commented
Jun 23, 2025
| } | ||
|
|
||
| fn extract_parameters_from_content(content: &str) -> Result<Option<Vec<RecipeParameter>>> { | ||
| let lines = content.lines(); |
Collaborator
Author
There was a problem hiding this comment.
@DOsinga Is this block of logic is intentional? Just to confirm as I have deleted.
lifeizhou-ap
commented
Jun 23, 2025
| } | ||
|
|
||
| // If we didn't find a parameter block it might be because it is defined in json style or some such: | ||
| if serde_yaml::from_str::<serde_yaml::Value>(content).is_err() { |
Collaborator
Author
There was a problem hiding this comment.
@DOsinga do we still need below as the next block also parse the content to recipe?
serde_yaml::from_str::<serde_yaml::Value>(content).is_err()
also shall we parse both json and yaml file here?
Collaborator
There was a problem hiding this comment.
any json file is also yaml, so no need to parse that twice
DOsinga
approved these changes
Jun 23, 2025
jessejacksonafterpay
added a commit
to jessejacksonafterpay/goose
that referenced
this pull request
Jun 24, 2025
…text-addition * upstream/main: fix temporal build for windows (block#3045) fix cron parsing for windows (block#3044) feat: list Databricks-supported models and enable fuzzy search during model configuration (block#3039) fix: update index when tool selection strategy changes (block#2991) docs: Add "Add Recipe button" To Recipe Cookbook (block#3038) fix: issue when parsing recipe parameters (block#3031) fix: Improves reliability of flaky log tests (block#3029)
michaelneale
added a commit
that referenced
this pull request
Jun 24, 2025
* main: fix temporal build for windows (#3045) fix cron parsing for windows (#3044) feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039) fix: update index when tool selection strategy changes (#2991) docs: Add "Add Recipe button" To Recipe Cookbook (#3038) fix: issue when parsing recipe parameters (#3031)
btdeviant
pushed a commit
to btdeviant/goose
that referenced
this pull request
Jun 25, 2025
laanak08
added a commit
that referenced
this pull request
Jun 26, 2025
# By Alice Hau (6) and others # Via Alice Hau * ahau/tool-strategy: (27 commits) fix merge merged updated computercontroller and developer descriptions add additional strats to test fmt update to get vector db path from env var feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039) fix: update index when tool selection strategy changes (#2991) docs: Add "Add Recipe button" To Recipe Cookbook (#3038) fix: issue when parsing recipe parameters (#3031) fix: Improves reliability of flaky log tests (#3029) Add xAI Test Coverage (#3020) Reorganizing tutorials (#3028) feat(providers): update Google Gemini models to latest available models (#2989) fix(docker): install protoc to fix lance-encoding build (#2995) fix: updated openrouter known models (#3021) Mnovich/temporal foreground tasks (#2895) add 'install in goose' asset (#3016) Added useDarkMode hook for detecting dark mode setting dynamically (#3019) docs: add sagemaker provider (#2980) ... # Conflicts: # .gitignore # crates/goose/src/agents/router_tools.rs
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When running a recipe with parameters, it shows error mssage:
Missing definitions for parameters in the recipe file: dateWhat
Removed code to parsing parameter block line by line. The logic seems like: when the "parameters" line is reached, and then return empty parameters.
Modified the test cases with correct
blocksection as example so that parameters can be parsed properlyAsked a couple questions as inline comments to be confirmed