Skip to content

Conversation

@lily-de
Copy link
Contributor

@lily-de lily-de commented Mar 25, 2025

Refactors models component to:

  1. Only show current model and provider
  2. Get suggested model names from providermetadata but still allow users to type in any model name they want
  3. Updates the bottom bar (idk why the modal looks different -- some text styles are different for chatview vs settings view maybe?)

video below shows bottom bar and model settings in both light and dark mode and takes you through a configure models flow

Screen.Recording.2025-03-25.at.6.40.52.PM.mov

<BottomMenuModeSelection />

{/* Model Selector Dropdown - Only in development */}
<div className="relative flex items-center ml-auto mr-4" ref={dropdownRef}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love all the red. My only Q is whether this is changing the functionality without process.env.ALPHA being checked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saved it :) nice catch

import { useConfig } from '../../../ConfigContext';
import { getCurrentModelAndProviderForDisplay } from '@/src/components/settings_v2/models';

export default function CurrentModelProvider(arg) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was a prototype -- deleted!

@lily-de lily-de merged commit f098fed into main Mar 26, 2025
6 checks passed
@lily-de lily-de deleted the ldelalande/models-dropdown branch March 26, 2025 01:06
michaelneale added a commit that referenced this pull request Mar 26, 2025
* main:
  ui: turn on extensions at startup (#1861)
  ui: models dropdown (#1860)
  fix: cli empty line (#1856)
  feat: Allow setting OpenAI timeout from config (#1819)
  feat: add retry for google (#1854)
  feat(extensions): add Java/JDK support for MCP servers (#1816)
  feat: extract `StdioProcessError(msg)` to try to display (#1855)
  fix: show window bugfix (#1840)
  fix: append the attachment path to the existing text in the input prompt (#1842)
  docs: updated docs for smart approval mode (#1853)
  styles: chat scroll interaction (#1837)
  ui: add description field  to modal (#1846)
  feat: use temp dir for extracting goose binary (#1838)
  ui: remove and update extensions (#1847)
  fix: disappearing user text when stopped (#1839)
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants