ci: pin github action to specific hash #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@oreparaz Do you mind resolving conflicts and then I can do a quick review after that |
michaelneale
approved these changes
Mar 25, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
great idea and long overdue
oreparaz
force-pushed
the
oscar/2025-03-20/pin-github/action
branch
from
875c8ac to
1032876
Compare
We do not want a compromised github action (or maintainer thereof) to take over the repo's secrets or integrity. This PR pins every action to a full length commit SHA. This is the way recommended by github [0]. The following tool was used in this PR: https://github.com/mheap/pin-github-action [0] https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
oreparaz
force-pushed
the
oscar/2025-03-20/pin-github/action
branch
from
1032876 to
b3d0eee
Compare
Contributor
Author
|
👌 resolved conflicts and rebased @zakiali |
zakiali
approved these changes
Mar 26, 2025
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want a compromised github action (or maintainer thereof) to take over the repo's secrets or integrity. This PR pins every action to a full length commit SHA.
This is the way recommended by github [0]. The following tool was used in this PR: https://github.com/mheap/pin-github-action
Example vulnerability that exploits this vector: GHSA-mrrh-fwg8-r2c3 (CVE-2025-30066).
[0] https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions