Skip to content

Conversation

@yingjiehe-xyz
Copy link
Contributor

@yingjiehe-xyz yingjiehe-xyz commented Mar 5, 2025

Partially revert the #1533 because it introduce the issue that when we switch from approve/auto mode to chat mode in one session, we will see Requests which include tool_use or tool_result blocks must define tools..

Test:

( O)> write a demo.txt under my current dir
I'll help you create a demo.txt file in your current directory using the text editor tool.
─── text_editor | developer ──────────────────────────
path: ~/Documents/block/goose/demo.txt
command: write
file_text: ...

◇  Goose would like to call the above tool, do you approve?
│  Yes 
│
### /Users/yingjiehe/Documents/block/goose/demo.txt
This is a demo text file.
It was created using Goose's text editor tool.

Feel free to modify this file as needed!

I've created a demo.txt file with some sample content. Let's verify that the file was created successfully:
─── shell | developer ──────────────────────────
command: ls -l demo.txt


-rw-r--r--  1 yingjiehe  staff  114 Mar  5 16:14 demo.txt

The file has been created successfully! You can view its contents using the text editor or modify it as needed. Would you like to see the contents of the file to verify?
( O)> /mode chat
Goose mode set to 'chat'
( O)> write a test.txt under my current dir
I'll help you create a test.txt file in your current directory using the text editor tool.
─── text_editor | developer ──────────────────────────
path: ~/Documents/block/goose/test.txt
command: write
file_text: ...


I notice that I'm currently in chat-only mode without access to tools. Here's what the above command would do if tools were available:

1. Create a new file named `test.txt` in `/Users/yingjiehe/Documents/block/goose/`
2. Write the following content to the file:
   This is a test text file.
   Created for testing purposes.

   You can add more content or modify this file as needed.
3. Verify the file creation was successful

To actually create this file, you would need to run Goose with tool access enabled. Would you like to know how to enable tool access, or would you prefer to create the file through other means?
Screen.Recording.2025-03-05.at.3.44.34.PM.mov

@yingjiehe-xyz yingjiehe-xyz requested a review from wendytang March 5, 2025 23:43
@yingjiehe-xyz yingjiehe-xyz marked this pull request as ready for review March 5, 2025 23:43
@yingjiehe-xyz yingjiehe-xyz merged commit e52e547 into main Mar 6, 2025
6 checks passed
@yingjiehe-xyz yingjiehe-xyz deleted the yingjiehe/fix branch March 6, 2025 19:11
michaelneale added a commit that referenced this pull request Mar 7, 2025
* main:
  bugfix: refactor workdirs to be async-safe, and simpler (#1558)
  feat: split required_extensions in bench to builtin/external (#1547)
  fix: continue to use resumed session after confirmation is cancelled (#1548)
  feat: add image tool to developer mcp (#1515)
  docs: using gooseignore (#1554)
  ci: use cargo update --workspace to ensure Cargo.lock is updated (#1539)
  fix: respond to interrupted tool calls with a ToolResponseMessageContent (#1557)
  fix: get tool def back to chat mode (#1538)
  ui: add default icon (#1553)
  fix: fix summarize agent, use session_id and add provider fn (#1552)
  feat(agent): memory condensation for longer context (#1457)
  docs: goose tips blog (#1550)
  docs: update to provider view (#1546)
  docs: resuming sessions (#1543)
  feat: goose bench framework for functional and regression testing
  feat: use refresh_tokens from databricks api (#1517)
  feat: use Ctrl/Cmd + ↑/↓ to navigate message history (#1501)
  feat: remove tools from chat mode (#1533)
  feat: use dropdown for goose selection (#1531)
  docs: goosehints in desktop (#1529)
lily-de pushed a commit that referenced this pull request Mar 7, 2025
ahau-square pushed a commit that referenced this pull request Mar 7, 2025
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants