feat: use Ctrl/Cmd + ↑/↓ to navigate message history #1501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-square
changed the title
| handleSubmit: (e: React.FormEvent) => void; | ||
| isLoading?: boolean; | ||
| onStop?: () => void; | ||
| commandHistory?: string[]; |
Contributor
There was a problem hiding this comment.
do we want to maintain a fixed size array?
Contributor
Author
There was a problem hiding this comment.
Hi @yingjiehe-xyz , what do you mean a "fixed size array"? In JavaScript the array size is not fixed.
Or are you suggesting the max size of the array for performance consideration? I think that is not necessary here too.
Contributor
There was a problem hiding this comment.
sorry for the confusing, yes, the max size for history, I think so, not too many messages right now
Contributor
yingjiehe-xyz
left a comment
yingjiehe-xyz
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
yingjiehe-xyz
approved these changes
Mar 5, 2025
Contributor
Author
|
Hi @yingjiehe-xyz would you merge this PR? I don't see the merge button here. Thanks |
Contributor
oh, I thought you could merge it, my bad |
michaelneale
added a commit
that referenced
this pull request
Mar 7, 2025
* main: bugfix: refactor workdirs to be async-safe, and simpler (#1558) feat: split required_extensions in bench to builtin/external (#1547) fix: continue to use resumed session after confirmation is cancelled (#1548) feat: add image tool to developer mcp (#1515) docs: using gooseignore (#1554) ci: use cargo update --workspace to ensure Cargo.lock is updated (#1539) fix: respond to interrupted tool calls with a ToolResponseMessageContent (#1557) fix: get tool def back to chat mode (#1538) ui: add default icon (#1553) fix: fix summarize agent, use session_id and add provider fn (#1552) feat(agent): memory condensation for longer context (#1457) docs: goose tips blog (#1550) docs: update to provider view (#1546) docs: resuming sessions (#1543) feat: goose bench framework for functional and regression testing feat: use refresh_tokens from databricks api (#1517) feat: use Ctrl/Cmd + ↑/↓ to navigate message history (#1501) feat: remove tools from chat mode (#1533) feat: use dropdown for goose selection (#1531) docs: goosehints in desktop (#1529)
lily-de
pushed a commit
that referenced
this pull request
Mar 7, 2025
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement the feature request in issue.
We decide to implement the
Ctrl/Cmd + ↑/↓option to navigate through the history message.Screen.Recording.2025-03-04.at.3.59.33.PM-1.mov