Making stats computed using DiskStatsReporter optional #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Doesn't feel like the right place for this at all. |
Member
|
I think it's ok to collect bytesRead within zap, so I'd recommend against this change. |
Thejas-bhat
force-pushed
the
statsUnderFlag
branch
from
d9c588a to
0cefbe5
Compare
written at index time
Thejas-bhat
force-pushed
the
statsUnderFlag
branch
from
0cefbe5 to
1f7ad96
Compare
| // to reset the bytes read value to a consistent | ||
| // value during operations such as merging of segments. | ||
| ResetBytesRead(uint64) | ||
| // BytesRead returns the bytes written to disk while |
abhinavdangeti
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface for disk stats introduced in PR #1702, #17 and #15
are currently computed all time the irrespective of whether or not its needed. Since it is in a fairly hot code path, it could affect the performance when these stats are not needed. Hence, this PR aims to hide those stats computation behind a flag which controls the same.