Skip to content

Making stats computed using DiskStatsReporter optional #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Making stats computed using DiskStatsReporter optional #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb771b1
Introduced a flag, which allows IO stats computation when set true
Thejas-bhat Jul 14, 2022
1f7ad96
introducing a new method is DiskStatsReporter which returns the bytes
Thejas-bhat Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion segment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,16 @@ type PostingsIterator interface {
}

type DiskStatsReporter interface {
// BytesRead returns the bytes read from the disk as
// part of the current running query.
BytesRead() uint64
SetBytesRead(uint64)
// ResetBytesRead is used by the parent layer
// to reset the bytes read value to a consistent
// value during operations such as merging of segments.
ResetBytesRead(uint64)
// BytesRead returns the bytes written to disk while
Copy link
Member

@abhinavdangeti abhinavdangeti Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BytesWritten*

// building an index
BytesWritten() uint64
}

type OptimizablePostingsIterator interface {
Expand Down