Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiline value parsing regressions reported in v2.3.0 #346

Merged
merged 10 commits into from
Jun 14, 2018
Merged

Fix multiline value parsing regressions reported in v2.3.0 #346

merged 10 commits into from
Jun 14, 2018

Commits on Apr 25, 2018

  1. Test to address regression in bkeepers#339

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    3802638 View commit details
    Browse the repository at this point in the history

  2. Parse multi-line values properly (e.g. Heroku config export)

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    3ef2d90 View commit details
    Browse the repository at this point in the history

  3. Fix original regex to escape slash

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    16e4368 View commit details
    Browse the repository at this point in the history

  4. Match multiple lines

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    af7efd9 View commit details
    Browse the repository at this point in the history

  5. Add tests for parsing multi-line values

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    59a1ca0 View commit details
    Browse the repository at this point in the history

  6. Fix Rubocop offenses

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    edf934b View commit details
    Browse the repository at this point in the history

  7. Update README with multi-line value improvements

    @joelvh
    joelvh committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    f545408 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2018

  1. Replace "\r" characters with "\n" for consistent new line matching

    @joelvh
    joelvh committed May 7, 2018
    Configuration menu
    Copy the full SHA
    348ccf0 View commit details
    Browse the repository at this point in the history

  2. Match beginning of line to make sure the line is not commented out

    @joelvh
    joelvh committed May 7, 2018
    Configuration menu
    Copy the full SHA
    9837862 View commit details
    Browse the repository at this point in the history

  3. Don't match greedy spaces to avoid matching a new line when there is … 

    …no value
    @joelvh
    joelvh committed May 7, 2018
    Configuration menu
    Copy the full SHA
    6fd3d71 View commit details
    Browse the repository at this point in the history