Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline value parsing regressions reported in v2.3.0 #346

Merged
merged 10 commits into from
Jun 14, 2018

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented May 7, 2018

Fixes #343
Fixes #344

@joelvh joelvh mentioned this pull request May 7, 2018
@cadwallion cadwallion self-assigned this Jun 13, 2018
Copy link
Collaborator

@cadwallion cadwallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for the fix, sorry for the wait!

@joelvh
Copy link
Contributor Author

joelvh commented Jun 13, 2018

Thanks! Hope this resolves things sufficiently for everyone.

@cadwallion cadwallion merged commit d0c55dc into bkeepers:master Jun 14, 2018
@trevorcreech
Copy link

@cadwallion would it be possible to get a version bump so this change shows up in rubygems.org?

@cadwallion
Copy link
Collaborator

I'll get a version bump released tonight!

@cadwallion
Copy link
Collaborator

This was shipped in version 2.5.0 a few minutes ago.

@trevorcreech
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants