Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL-335][CL-336][CL-374] Announce toasts more consistently #13167
base: main
Are you sure you want to change the base?
[CL-335][CL-336][CL-374] Announce toasts more consistently #13167
Changes from 5 commits
b95d273
7a7e6ac
9579d77
e57352b
321b9ba
e0fbe9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 96 in apps/desktop/src/app/app.component.ts
apps/desktop/src/app/app.component.ts#L96
Check warning on line 14 in libs/components/src/toast/toast-container.component.ts
libs/components/src/toast/toast-container.component.ts#L14
Check warning on line 17 in libs/components/src/toast/toast-container.component.ts
libs/components/src/toast/toast-container.component.ts#L17
Check warning on line 32 in libs/components/src/toast/toastr.component.ts
libs/components/src/toast/toastr.component.ts#L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โน๏ธ storybookjs/storybook#23534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find