[CL-335][CL-336][CL-374] Announce toasts more consistently #13167
+78
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (10)Checkmarx found the following issues in this Pull Request
Fixed Issues (2)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13167 +/- ##
==========================================
- Coverage 35.48% 35.06% -0.43%
==========================================
Files 3007 3037 +30
Lines 90872 92727 +1855
Branches 16904 16888 -16
==========================================
+ Hits 32250 32511 +261
- Misses 56120 57753 +1633
+ Partials 2502 2463 -39 ☔ View full report in Codecov by Sentry. |
willmartian
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Bug solution looks good, but I would change the way we expose it to consumers of the lib. Issues with current approach:
- An external dep / implementation detail is now exposed to the public API, here and here
- This goes against a code style I want to follow for the CL, the facade pattern. I will add this to our CL code style docs.
- We are duplicating some logic in each app component.
I think both of these issues are fixed by creating small container component: bit-toast-container. It could directly set ToastrService.overlayContainer with a reference to itself. That component could then be used in the app components.
willmartian
previously approved these changes
Feb 5, 2025
vleague2
commented
Feb 5, 2025
Comment on lines
+31
to
+32
| constructor(toastrService: ToastrService, toastPackage: ToastPackage) { | ||
| super(toastrService, toastPackage); |
There was a problem hiding this comment.
willmartian
previously approved these changes
Feb 5, 2025
Comment on lines
+31
to
+32
| constructor(toastrService: ToastrService, toastPackage: ToastPackage) { | ||
| super(toastrService, toastPackage); |
willmartian
changed the title
vleague2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-335
CL-336
CL-374
📔 Objective
This PR adds the following screenreader functionality to our toasts in all 3 clients:
aria-live="polite"(which isngx-toastr's default) as well as adding a role ofstatusandaria-atomicto improve the consistency of toasts being announced. Some circumstances are not addressed by this fix, namely toasts not being announced when focus is lost.aria-role="alert"on the toast when it is an error toast, which makes sure that screenreaders announce error messagesThis PR also fixes a couple of issues related to Storybook:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes