-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2944. promisify send modal #2976
#2944. promisify send modal #2976
Conversation
@OpenLedgerApp what was your time on this? |
@startailcoon I suppose about 3h |
Feels like a lot for such a small change, but I assume it's been fully debugged and tested. I would like a more detailed explanation of the time taken. |
app/components/Modal/SendModal.jsx
Outdated
@@ -168,19 +168,47 @@ class SendModal extends React.Component { | |||
}); | |||
} | |||
|
|||
fetchToAccount(toName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you make both fetchTo and fetchFrom, and then even with an accountName argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
What does suppose mean? I would expect proper time tracking from company contributions. There are also still several instances of un-promisified data fetching. @startailcoon is providing a fix for the account selector, so I please do not continue at the moment |
@startailcoon |
Needs re-evaluation with restructuring of SendModal due to FeeAssetSelector |
General
Closes #2944refactoring
General
Please make sure the following is done:Code Preparation
Please review all your changes one last time before committing
Testing
The branch has been tested on the following browsers (desktop and mobile view)
User interface changes
Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes
Please provide screenshots/licecap of your changes below