Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Promisify SendModal #2944

Open
sschiessl-bcp opened this issue Jul 15, 2019 · 2 comments
Open

[3] Promisify SendModal #2944

sschiessl-bcp opened this issue Jul 15, 2019 · 2 comments
Assignees
@OpenLedgerApp
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours

Comments

@sschiessl-bcp
Copy link
Contributor

I always feel that the
let account = ChainStore.getAccount(accountName); is abusing the re-render and Promise premise. Very often you see afterwards if (account) which then triggers the rendering, but this needs a possibly never happening re-render of the component.

I want the SendModal to use Promises in a proper way (e.g. through FetchChainObject or any of the other promisified functions). This issue is for refactoring accordingly.
@sschiessl-bcp sschiessl-bcp added this to the Active Development milestone Jul 15, 2019
@startailcoon startailcoon added [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours labels Jul 15, 2019
@startailcoon
Copy link
Contributor

@OpenLedgerApp what's your estimation on this. As it needs some work I expect it to be a few hours at least. I'll set the estimation to 4 for now, let me know if it falls short.

@startailcoon startailcoon changed the title Promisify SendModal [4] Promisify SendModal Jul 21, 2019
@clockworkgr clockworkgr modified the milestones: 190719, 190802 Jul 23, 2019
OpenLedgerApp pushed a commit to OpenLedgerApp/bitshares-ui that referenced this issue Jul 24, 2019
bitshares#2944. refactoring
1c989f7
@OpenLedgerApp OpenLedgerApp mentioned this issue Jul 24, 2019
Closed
12 tasks
@startailcoon startailcoon changed the title [4] Promisify SendModal [1] Promisify SendModal Jul 24, 2019
@startailcoon startailcoon changed the title [1] Promisify SendModal [3] Promisify SendModal Jul 29, 2019
@sschiessl-bcp sschiessl-bcp modified the milestones: 190802, 190816 Aug 11, 2019
@startailcoon startailcoon modified the milestones: 190816, 190830 Aug 17, 2019
@sschiessl-bcp
Copy link
Contributor Author

Needs re-evaluation with restructuring of SendModal due to FeeAssetSelector

@sschiessl-bcp sschiessl-bcp removed this from the 190830 milestone Nov 4, 2019
@AndreiShybin AndreiShybin mentioned this issue Mar 9, 2021
Open
@AndreiShybin AndreiShybin mentioned this issue Oct 6, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OpenLedgerApp OpenLedgerApp

Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2944. promisify send modal OpenLedgerApp/bitshares-ui
4 participants
@clockworkgr @startailcoon @sschiessl-bcp @OpenLedgerApp