Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040

Closed
sschiessl-bcp opened this issue Aug 19, 2019 · 1 comment · Fixed by #3076
Closed

[3] Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040

sschiessl-bcp opened this issue Aug 19, 2019 · 1 comment · Fixed by #3076
Assignees
@sschiessl-bcp
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5a] Tiny Indicates size of task. Est. less than one hour
Milestone
191217

Comments

@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Aug 19, 2019 •
edited
Loading

https://bitsharestalk.org/index.php?topic=29284.0

Currently error messages from core are displayed as is. With the 3.2.0 update we can give a better visualization of the error.

Task:

  • check where in UI the raw core error is displayed (i think only transactionconfirm dialog), and report back here
  • adjust the transaction confirm dialog such that it can handle both error reponses (old core, and new json error response starting with 3.2.0)
  • for new json error response display "code - message" as the error string. if "data" is present, add a "Show more" clickable text that if clicked shows "data"
  • on error, check the error response to handle the old response the old way and the new response the new way
@sschiessl-bcp sschiessl-bcp self-assigned this Aug 19, 2019
@sschiessl-bcp sschiessl-bcp mentioned this issue Aug 19, 2019
Closed
@startailcoon startailcoon added [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5a] Tiny Indicates size of task. Est. less than one hour labels Aug 19, 2019
@startailcoon startailcoon added this to the 190830 milestone Aug 19, 2019
@startailcoon startailcoon changed the title Asset creation throws Execution error [1] Asset creation throws Execution error Aug 19, 2019
@abitmore
Copy link
Member

abitmore commented Aug 19, 2019 •
edited
Loading

Starting from bitshares-core 3.2.0 release we updated JSON-RPC server to follow a standard about error reporting. Perhaps this is a side-effect of the change.

bitshares/bitshares-core#1688
bitshares/bitshares-fc#135, specifically, https://github.com/bitshares/bitshares-fc/pull/135/files#diff-9951baf01c215b843389e161aebbaabdR221

The specification is https://www.jsonrpc.org/specification

Please create an issue in bitshares-core repository if something we've done wrongly.

@sschiessl-bcp sschiessl-bcp changed the title [1] Asset creation throws Execution error Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 Aug 20, 2019
@sschiessl-bcp sschiessl-bcp changed the title Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 [3] Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 Aug 20, 2019
@sschiessl-bcp sschiessl-bcp modified the milestones: 190830, 190927 Sep 26, 2019
This was referenced Sep 26, 2019
Merged
Merged
sschiessl-bcp pushed a commit that referenced this issue Oct 9, 2019
Merge pull request #3076 from blockchainprojects/#3040_Adapt_error_me…
abe7c49 
…ssages_to_new_JSON-RPC_of_bitshares-core_3.2.0

#3040 adapt error messages to new json rpc of bitshares core 3.2.0
@sschiessl-bcp sschiessl-bcp mentioned this issue Nov 8, 2019
Closed
@AndreiShybin AndreiShybin mentioned this issue Mar 9, 2021
Open
@AndreiShybin AndreiShybin mentioned this issue Oct 6, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschiessl-bcp sschiessl-bcp

Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5a] Tiny Indicates size of task. Est. less than one hour
Projects
None yet
Milestone
191217
Development

Successfully merging a pull request may close this issue.

#3040 adapt error messages to new json rpc of bitshares core 3.2.0 blockchainprojects/bitshares-ui
3 participants
@abitmore @startailcoon @sschiessl-bcp