Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040 #185

Closed
sschiessl-bcp opened this issue Aug 19, 2019 · 1 comment
Closed

[3.5] Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040 #185

sschiessl-bcp opened this issue Aug 19, 2019 · 1 comment
Assignees
@Metizik

Comments

@sschiessl-bcp
Copy link
Collaborator

bitshares#3040
@sschiessl-bcp sschiessl-bcp changed the title Asset creation throws Execution error #3040 Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040 Aug 20, 2019
@Metizik Metizik self-assigned this Aug 21, 2019
@Metizik
Copy link
Collaborator

Metizik commented Aug 23, 2019

@sschiessl-bcp , regarding this issue there are few questions to clarify:

  1. The error handling logic is now hidden in TransactionBuilder of bitsharesjs. So to implement requested adoption I need to modify bitsharesjs codebase, or there is another preferred way here?
  2. After changes applied - do we need to maintain older JSON-RPC version compatibility? If so, is there any nodes with older JSON-RPC I can test compatibility against?

@Metizik Metizik mentioned this issue Aug 27, 2019
Closed
12 tasks
@VerevkinAlexander VerevkinAlexander mentioned this issue Aug 30, 2019
Closed
@sschiessl-bcp sschiessl-bcp changed the title Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040 [3.5] Adapt error messages to new JSON-RPC of bitshares-core 3.2.0 #3040 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Metizik Metizik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3040 adapt error messages to new json rpc of bitshares core 3.2.0 blockchainprojects/bitshares-ui
3 participants
@Metizik @sschiessl-bcp @VerevkinAlexander