Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC logging level inconsistency #929 #62

Merged
merged 2 commits into from
Jul 23, 2018
Merged

RPC logging level inconsistency #929 #62

merged 2 commits into from
Jul 23, 2018

Conversation

cogutvalera
Copy link
Member

@cogutvalera cogutvalera commented Jul 17, 2018 •
edited
Loading

@cogutvalera cogutvalera mentioned this pull request Jul 17, 2018
Closed
8 tasks
abitmore
abitmore previously approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@cogutvalera
Copy link
Member Author

@abitmore Thank you very much !

@abitmore abitmore mentioned this pull request Jul 17, 2018
Closed
@cogutvalera
Copy link
Member Author

should I close this pull request ? or not ?

pmconrad
pmconrad suggested changes Jul 17, 2018
View reviewed changes
Copy link

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add this to websocket_tls_server_impl.
Please check for other places as well.

@pmconrad
Copy link

should I close this pull request ? or not ?

Just keep it open until we have merged it.

@cogutvalera
Copy link
Member Author

cogutvalera commented Jul 17, 2018 •
edited
Loading

Just keep it open until we have merged it.

OK. Sure ! Thx !

Also need to add this to websocket_tls_server_impl.
Please check for other places as well.

OK. I will check.

@cogutvalera
Copy link
Member Author

@pmconrad I've added log for websocket_tls_server_impl but cannot find other places.

@cogutvalera
Copy link
Member Author

I don't see any other places for logs, is this issue finished or not yet ? Should I do any changes here or not ?

@nanomobile
Copy link

Thanks !

@cogutvalera cogutvalera changed the title fixed issue #929 RPC logging level inconsistency #929 Jul 21, 2018
@abitmore abitmore merged commit ed168a4 into bitshares:master Jul 23, 2018
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

@abitmore abitmore abitmore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cogutvalera @pmconrad @nanomobile @abitmore