Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC logging level inconsistency #929

Closed
4 of 8 tasks
abitmore opened this issue May 16, 2018 · 20 comments
Closed
4 of 8 tasks

RPC logging level inconsistency #929

abitmore opened this issue May 16, 2018 · 20 comments
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2h Accepted Status indicating the solution passed final review, and is ready for implementation 3c Enhancement Classification indicating a change to the functionality of the existing imlementation logging

Comments

@abitmore
Copy link
Member

abitmore commented May 16, 2018

As described in #802 (comment), RPC related logging level is:

  • level=error : logs errors
  • level=warn : logs requests
  • level=info : logs responses

However, it only applies to websocket connection, as mentioned in #919 (review):

For simple requests with curl I didn't see responses being logged at level "info".

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone May 16, 2018
@ryanRfox ryanRfox added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2a Discussion Needed Prompt for team to discuss at next stand up. 3a Request Classification (default) which does not fit as a Feature, Enhancement or Bug. Core Team to evaluate labels May 23, 2018
@nanomobile
Copy link
Contributor

@ryanRfox can I claim this issue please ?

@ryanRfox
Copy link
Contributor

Yes, I'll move it to Community Claims for you @nanomobile . Prior to beginning work, we need to establish an estimate on the effort. May I request you to provide your estimate here? I will work with the Core Team to confirm, then you may begin development based on that estimate. Thanks

@nanomobile
Copy link
Contributor

nanomobile commented Jun 29, 2018

@ryanRfox
Thank you very much ! A bit later I will provide my estimate here ...

@nanomobile
Copy link
Contributor

nanomobile commented Jun 29, 2018

my estimation for this issue is approximately 2 hours. @ryanRfox @jmjatlanta @oxarbitrage @clockworkgr @abitmore @xeroc what is your approximation ?

@abitmore
Copy link
Member Author

abitmore commented Jul 1, 2018

I'm fine with that.

@nanomobile
Copy link
Contributor

I don't know if 2 hours will be enough or not for this issue, it's just my approximation :-) maybe your approximation guys would be much better suited for this issue

@cogutvalera
Copy link
Member

I need to resolve #1141 issue and only after that I will can resolve this issue

@ryanRfox ryanRfox added the 0 BLOCKED Notification to Core Team that Assignee is unable to proceed. Need impediment removed. label Jul 15, 2018
@abitmore abitmore added 3c Enhancement Classification indicating a change to the functionality of the existing imlementation and removed 0 BLOCKED Notification to Core Team that Assignee is unable to proceed. Need impediment removed. 3a Request Classification (default) which does not fit as a Feature, Enhancement or Bug. Core Team to evaluate labels Jul 16, 2018
@cogutvalera
Copy link
Member

breakpoints work on wscat requests but not on cURL requests. For example exactly this line of code https://github.com/bitshares/bitshares-fc/blob/0a90eff69778c0ef1d26f75d11d459ca172eff0c/src/network/http/websocket.cpp#L161 can be stopped by breakpoint for wscat requests on sending result, but on cURL requests breakpoints here won't work.

Can anybody help me to find exactly the line of code where response is sending on cURL requests for wintess_node ?

@abitmore
Copy link
Member Author

Forwarded comment/question from #1141:

Also @abitmore I don't want to debug with a specific tool, I just want to debug with any tool but I've tried different debugging tools and cannot debug just some little part in fc library, at the same time other parts of the same fc library I can debug with different debugging tools. @abitmore can you help me please to debug with any debugging tool specific cURL requests for witness_node ? which tool do you suggest for this purpose ? I think if it is really basic programming skills for you than you should help me and after that close this issue :-)

Sorry, to me, this issue is low priority, so I won't spend time on it right now. You claimed it, that means it's your issue, best if you can get it resolved with your own efforts, nobody else is responsible for helping you, although someone will help sometimes.

@abitmore
Copy link
Member Author

Another comment forwarded from #1141:

Common causes of breakpoints not working:

  • The line was never run. This is a common problem that catches even the best developers at times. Step into the function call instead of using breakpoints, and make sure the method you expect to have been called is actually called.
  • library not built with debugging information (probably not the case here, as you can debug other stuff in the same library)
  • code not compiled in ( line 17 is a blank line according to the debugging information, but is an actual line in your new code that has yet to be compiled with debugging information turned on)

@nanomobile please read it, especially the first cause, I guess you've encountered it.

@cogutvalera
Copy link
Member

@abitmore I don't want that you help me right now, I'm always trying with my own efforts, just want to make informational discussion history here for all other developers maybe will be useful later ...
While nobody can help me of course I will try to solve all my issues only by my own efforts as soon as possible ! Hope I will solve it by myself much earlier than help will come :-) I'm writing here in github without meaning that somebody must answer right now to me or right now must help me, no no no :-) just want to make some kind of documentation, while trying to solve my issues with my own efforts only, and maybe somebody knows the answer because had similar experience earlier :-) and can help me just by writing 1 simple sentence only :-) I don't want to waste your time or any others time !

@cogutvalera
Copy link
Member

I should shape my words another way without "can anybody help me" so people will understand my messages or questions more correctly

@cogutvalera
Copy link
Member

@ryanRfox
Copy link
Contributor

Added assignment to @cogutvalera and estimation of 2 horus to Description.

@ryanRfox
Copy link
Contributor

fixed by RPC logging level inconsistency #62 /bitshares/bitshares-fc/#62

@abitmore
Copy link
Member Author

Still need to bump FC. Reopened.

@cogutvalera
Copy link
Member

@abitmore still I need to bump FC here ? Thanks !

@abitmore
Copy link
Member Author

Will close this after merged #1104 .

@cogutvalera
Copy link
Member

Thanks !

@jmjatlanta jmjatlanta mentioned this issue Jul 27, 2018
@abitmore
Copy link
Member Author

Fixed with #1104.

@pmconrad pmconrad added 2h Accepted Status indicating the solution passed final review, and is ready for implementation and removed 2a Discussion Needed Prompt for team to discuss at next stand up. labels Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2h Accepted Status indicating the solution passed final review, and is ready for implementation 3c Enhancement Classification indicating a change to the functionality of the existing imlementation logging
Projects
None yet
Development

No branches or pull requests

5 participants