-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC logging level inconsistency #929
Comments
@ryanRfox can I claim this issue please ? |
Yes, I'll move it to Community Claims for you @nanomobile . Prior to beginning work, we need to establish an estimate on the effort. May I request you to provide your estimate here? I will work with the Core Team to confirm, then you may begin development based on that estimate. Thanks |
@ryanRfox |
my estimation for this issue is approximately 2 hours. @ryanRfox @jmjatlanta @oxarbitrage @clockworkgr @abitmore @xeroc what is your approximation ? |
I'm fine with that. |
I don't know if 2 hours will be enough or not for this issue, it's just my approximation :-) maybe your approximation guys would be much better suited for this issue |
I need to resolve #1141 issue and only after that I will can resolve this issue |
breakpoints work on wscat requests but not on cURL requests. For example exactly this line of code https://github.com/bitshares/bitshares-fc/blob/0a90eff69778c0ef1d26f75d11d459ca172eff0c/src/network/http/websocket.cpp#L161 can be stopped by breakpoint for wscat requests on sending result, but on cURL requests breakpoints here won't work. Can anybody help me to find exactly the line of code where response is sending on cURL requests for wintess_node ? |
Forwarded comment/question from #1141:
Sorry, to me, this issue is low priority, so I won't spend time on it right now. You claimed it, that means it's your issue, best if you can get it resolved with your own efforts, nobody else is responsible for helping you, although someone will help sometimes. |
Another comment forwarded from #1141:
@nanomobile please read it, especially the first cause, I guess you've encountered it. |
@abitmore I don't want that you help me right now, I'm always trying with my own efforts, just want to make informational discussion history here for all other developers maybe will be useful later ... |
I should shape my words another way without "can anybody help me" so people will understand my messages or questions more correctly |
Added assignment to @cogutvalera and estimation of 2 horus to Description. |
fixed by |
Still need to bump FC. Reopened. |
@abitmore still I need to bump FC here ? Thanks ! |
Will close this after merged #1104 . |
Thanks ! |
Fixed with #1104. |
As described in #802 (comment), RPC related logging level is:
level=error
: logs errorslevel=warn
: logs requestslevel=info
: logs responsesHowever, it only applies to websocket connection, as mentioned in #919 (review):
CORE TEAM TASK LIST
The text was updated successfully, but these errors were encountered: