Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default buckets. #466

Merged
merged 1 commit into from
Nov 9, 2017
Merged

update default buckets. #466

merged 1 commit into from
Nov 9, 2017

Conversation

oxarbitrage
Copy link
Member

#465

pull updates default buckets to something more standard with charting applications(1 min, 5 mins, 15 mins, 30 mins, 1 h, 4h and 1 day)

@abitmore
Copy link
Member

abitmore commented Nov 7, 2017

Need to add 30m as well? It's in the new code.

@oxarbitrage
Copy link
Member Author

oxarbitrage commented Nov 7, 2017 via email

@abitmore
Copy link
Member

abitmore commented Nov 7, 2017

Make a test to see how much more RAM is needed for the new buckets? I guess around 300M with current chain.

@oxarbitrage
Copy link
Member Author

yea, well, 5 buckets in current default tracking 1000 entires for each by default too.
we are removing one(15 seconds) and adding 3(15 mins - 30 mins - 4 hs). this should be an increase of 40% but i can get more exact numbers if i sync 2 chains. will do it tomorrow.

@oxarbitrage
Copy link
Member Author

i made a test today loading witness_node and market_history plugins(no account history data).
in the first sync with default values:

bucket-size = [15,60,300,3600,86400]

ram was: 4912548K after sync.

in a second ram with the new bucket numbers:

bucket-size = [60,300,900,1800,3600,14400,86400]

ram was: 4854132K

this was actually a surprise to me that the removal of the 15 seconds buckets reduced ram usage even if more bucket sizes were added.

a new try with this setup:

bucket-size = [15,60,300,900,1800,3600,14400,86400]

ram: 5137128K

what i think is happening is that new markets don't have enough data to fill the big buckets while pretty much all will fill the 15 seconds 1000 bucket size.

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@oxarbitrage oxarbitrage merged commit f47b1b9 into develop Nov 9, 2017
@abitmore abitmore added this to the Next Non-Consensus-Changing Release - 201712 milestone Nov 28, 2017
@abitmore abitmore deleted the oxarbitrage-patch-4 branch January 13, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants