Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appropriate buckets in order to add 15m and 4h Candlesticks #465

Closed
wmbutler opened this issue Nov 7, 2017 · 6 comments
Closed

Add appropriate buckets in order to add 15m and 4h Candlesticks #465

wmbutler opened this issue Nov 7, 2017 · 6 comments

Comments

@wmbutler
Copy link

wmbutler commented Nov 7, 2017

Current Candlesticks:

screen shot 2017-11-07 at 10 05 35 am

Our current bucket-size setting looks like this:

# Track market history by grouping orders into buckets of equal size measured in seconds specified as a JSON array of numbers
bucket-size = [15,60,300,3600,86400]

I do not know what needs to happen in order to add 15m and 4h candlesticks so I hope someone can comment on this issue and elaborate.

@oxarbitrage
Copy link
Member

for 15 mins you need to add 900 secs and for 4 hours 14400. a good setup will be:

bucket-size = [60,300,900,1800,3600,14400,86400]

for 1 min, 5 mins, 30 mins, 1h, 4 hs and 1 day. i think this should be the default.

@wmbutler
Copy link
Author

wmbutler commented Nov 7, 2017

The default build is set as shown in my first comment. Can you also update the source to set the new defaults so we don't have new nodes coming up with fewer buckets?

oxarbitrage added a commit that referenced this issue Nov 7, 2017
oxarbitrage added a commit that referenced this issue Nov 7, 2017
oxarbitrage added a commit that referenced this issue Nov 7, 2017
@oxarbitrage
Copy link
Member

#466
added. unsure if it will be approved as it will use more RAM and sometimes changing the defaults can break ongoing apps but i think it will be the best to have this numbers, even a weekly bucket can be added to it.

note: i committed directly to master the change by mistake and reverted back immediately, sorry about that.

@wmbutler
Copy link
Author

wmbutler commented Nov 7, 2017

900 = 15 mins. Just clarifying since you omitted that in your comment.

@oxarbitrage
Copy link
Member

yes, sorry, 900 seconds is 15 mins.

@oxarbitrage
Copy link
Member

merged change.

@abitmore abitmore added this to the Next Non-Consensus-Changing Release - 201712 milestone Nov 27, 2017
nikitakunevich pushed a commit to LocalCoinIS/LocalCoin-core that referenced this issue Jun 7, 2018
nikitakunevich pushed a commit to LocalCoinIS/LocalCoin-core that referenced this issue Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants