-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires api_helper_indexes plugin to start node #1889
Conversation
This is a warning on purpose. API nodes should enable the plugin because otherwise clients will receive incomplete information. Changing the log level to debug means the node owner won't notice his configuration problem. |
Perhaps we add an option so the admins who really want to disable the plugin can disable the logging? |
Hm, it feels wrong to add an option for a single log message. |
I think it's better to crash the node on start if we want to force the user to enable that plugin, than crash the node due to disk space issue after it's running for a few days. Better bother the admins once than twice. Then, it would be a good idea to add an option to avoid the crash. |
or start with --ignore-api-helper-indexes-warning. Don't silently write warning messages to P2P log.
abd014e
to
fa2248f
Compare
Force pushed. @pmconrad please review. |
IMO this option is annoying for non-API node admins. Please move the check into |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
#1836 introduced a
wlog
in constructor ofdatabase_api_impl
, this PR changes it todlog
becausewlog
will cause disk space issue on API nodes (see #1799 and #1798).