Keep track of collateral #1836
Merged
Keep track of collateral #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enable the new plugin by default? |
|
Good idea. Still should highlight this in the release notes. |
jmjatlanta
approved these changes
Jul 2, 2019
This was referenced Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1089
Resolves #1781
Note: the implementation via secondary index has the downside that subscriptions to asset objects will not get notified whenever the tracked values change. There is a precedent in
wallet_api:vesting_balance_object_with_infoalso contains additional values where changes are ignored on subscriptions.Note 2: the mechanism applied here, i. e. add the secondary indexes after replay, could be used on other indexes as well, which would help speed up replay. See discussion in #452 for example.