Fix CLI get_account_history pagination issue #1176 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test of account history pagination
oxarbitrage
approved these changes
Jul 27, 2018
There was a problem hiding this comment.
looks good to me, good job.
one thing we should maybe consider(in a separated issue) is to add a function in cli_wallet tests to make a few of the common things that we need to do pretty much in all the tests.
connect to the server
set wallet password
import Nathan account
upgrade nathan
verify that the upgrade was successful
create a new account
save the private key for this new account in the wallet file
...
this can be in a test case that can be invoked, a function or even maybe a "database_fixture" version file for the cli.
let me know if you guys think this worth to open an issue with low priority.
|
@oxarbitrage thanks. Created issue #1192 for cli_test refactory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1176.
Ideally we need a test case.