Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cli_test #1192

Closed
2 of 8 tasks
abitmore opened this issue Jul 27, 2018 · 4 comments
Closed
2 of 8 tasks

Refactor cli_test #1192

abitmore opened this issue Jul 27, 2018 · 4 comments
Assignees
@cogutvalera
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2d Developing Status indicating currently designing and developing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 6 Build Impact flag identifying the build process testing
Milestone
201810 - Feature ...

Comments

@abitmore
Copy link
Member

abitmore commented Jul 27, 2018 •
edited by ryanRfox
Loading

@oxarbitrage wrote in #1177 (review):

one thing we should maybe consider(in a separated issue) is to add a function in cli_wallet tests to make a few of the common things that we need to do pretty much in all the tests.
connect to the server
set wallet password
import Nathan account
upgrade nathan
verify that the upgrade was successful
create a new account
save the private key for this new account in the wallet file
...
this can be in a test case that can be invoked, a function or even maybe a "database_fixture" version file for the cli.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 10 hours (Remittance Weeks 34-35)
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore mentioned this issue Jul 27, 2018
Merged
@abitmore
Copy link
Member Author

abitmore commented Jul 27, 2018 •
edited
Loading

I think this issue is a good place for adding clean shutdown tests.

Update: perhaps not a good place? There are quite some logic in the main function in programs/cli_wallet/main.cpp, perhaps hard to test.

@cogutvalera
Copy link
Member

I want to claim this issue

@ryanRfox ryanRfox added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2d Developing Status indicating currently designing and developing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 6 Build Impact flag identifying the build process labels Aug 3, 2018
@cogutvalera
Copy link
Member

Thanks !

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 9, 2018
@cogutvalera
Refactor cli_test bitshares#1192
2a385bb
@cogutvalera cogutvalera mentioned this issue Aug 9, 2018
Merged
abitmore added a commit that referenced this issue Aug 29, 2018
@abitmore
Merge pull request #1243 from cogutvalera/issue_1192
0ad21dc 
Refactor cli_test #1192
@oxarbitrage
Copy link
Member

this was closed by #1243

@TheTaconator TheTaconator mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cogutvalera cogutvalera

Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2d Developing Status indicating currently designing and developing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 6 Build Impact flag identifying the build process testing
Projects
None yet
Milestone
201810 - Feature Release
Development

No branches or pull requests
4 participants
@abitmore @ryanRfox @oxarbitrage @cogutvalera